Review 11.5 Merged

80923[TASK] Simplify filesystem usage in PackageArtifactBuilder

Benjamin Franzke CR +2 V +2 Easy +17 −13 updated 09/08/23, 14:49

Commit message

Only create one filesystem object,
instead of always creating new ones where needed.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Benjamin Franzke uploaded patch set 1 09/08/23, 06:12

  2. core-ci voted on patch set 1 V +1 09/08/23, 06:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46372

  3. Benjamin Franzke updated the commit message in patch set 2 V +1 09/08/23, 07:14

  4. core-ci voted on patch set 2 V +1 09/08/23, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46375

  5. Benjamin Franzke voted on patch set 2 V +2 CR +2 09/08/23, 07:39

  6. Benjamin Franzke commented on patch set 2 09/08/23, 07:40

    Talked to Benni, we want this in v11.
  7. Benjamin Franzke merged patch set 3 09/08/23, 07:40

  8. Helmut Hummel commented on patch set 3 09/08/23, 14:49

    Reply

    fine with me!