Review main Merged

80925[TASK] Clean up `@typo3/backend/form-engine-validation` module

Andreas Kienast CR +2 V +2 Hard +159 −189 updated 10/27/23, 04:41

Commit message

* Removed referencing potentially hidden fields as "main field",
  lowering congnitive load
* Dropped most usage of jQuery
* Deprecated remaining jQuery usages, potentially used by 3rd party
  extensions
* Removed copying validator configuration in "human readable field"
* Event `t3-formengine-postfieldvalidation` is dispatched on the form,
  but bubbles up to `document`
* Try to avoid double dispatching the `change` event

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 3043

Show 1218 earlier messages
  1. Andreas Kienast uploaded patch set 1 09/08/23, 08:09

  2. core-ci voted on patch set 1 V -1 09/08/23, 08:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46376

  3. Oliver Klee commented on patch set 1 09/08/23, 08:44

    Typo: CLeanup -> clean up (with a lowercase “l”, and with a space, as the verb is “to clean up”, while the noun is “the cleanup”
  4. Andreas Kienast commented on patch set 1 09/08/23, 08:53

    Reply

    You're aware that you're reviewing a WIP patch that obviously has an incomplete message, right? 😊
  5. Andreas Kienast commented on patch set 1 09/08/23, 08:53

    Reply

    Done
  6. Andreas Kienast uploaded patch set 2 V -1 09/08/23, 11:38

  7. core-ci voted on patch set 2 V -1 09/08/23, 11:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46382

  8. Andreas Kienast uploaded patch set 3 V -1 09/08/23, 12:14

  9. core-ci voted on patch set 3 V -1 09/08/23, 12:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46386

  10. Andreas Kienast uploaded patch set 4 V -1 09/08/23, 12:36

  11. core-ci voted on patch set 4 V +1 09/08/23, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46389

  12. Andreas Kienast uploaded patch set 5 V +1 09/08/23, 12:59

  13. core-ci voted on patch set 5 V +1 09/08/23, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46394

  14. Andreas Kienast uploaded patch set 6 V +1 09/13/23, 09:47

  15. Oliver Klee wrote 09/13/23, 09:51

    Removed cc Oliver Klee.
  16. core-ci voted on patch set 6 V +1 09/13/23, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46534

  17. Andreas Kienast uploaded patch set 7 V +1 09/13/23, 13:19

  18. Andreas Kienast commented on patch set 7 CR -1 09/13/23, 13:20

    on it
  1. core-ci voted on patch set 7 V +1 09/13/23, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46547

  2. Andreas Kienast uploaded patch set 8 CR -1 V +1 09/13/23, 13:33

  3. core-ci voted on patch set 8 V +1 09/13/23, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46548

  4. Benjamin Franzke commented on patch set 8 CR -1 09/14/23, 08:10

    form-engine-validation.ts:396

    as already discussed in person: could be made non breaking using bubbles: true (therefore marking -1 for now, so we do not forget)
  5. Andreas Kienast uploaded patch set 9 CR -1 V +1 09/14/23, 09:44

  6. Andreas Kienast commented on patch set 9 09/14/23, 09:44

    form-engine-validation.ts:396 Reply

    Works as expected, thanks for the hint.
  7. core-ci voted on patch set 9 V +1 09/14/23, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46568

  8. Benjamin Franzke uploaded patch set 10 V +1 09/18/23, 12:46

  9. core-ci voted on patch set 10 V +1 09/18/23, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46664

  10. Andreas Kienast uploaded patch set 11 CR +1 V +1 09/26/23, 12:36

  11. core-ci voted on patch set 11 V +1 09/26/23, 12:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47184

  12. Stefan Bürk voted on patch set 11 V +1 09/26/23, 13:46

  13. Oliver Hader commented on patch set 11 CR +1 10/18/23, 13:38

    form-engine-validation.ts:89

    General question on "constructed DOM queries": Should be use `CSS.escape(fieldName)` instead - would apply to any other dynamic selector-part as well...
  14. Andreas Kienast commented on patch set 11 10/18/23, 13:50

    form-engine-validation.ts:89 Reply

    In general this is a good hint. I think this qualifies for a separate bugfix down to v11, right?
  15. Benjamin Franzke commented on patch set 11 10/19/23, 08:37

    form-engine-validation.ts:89 Reply

    Ack. I think some syntax sugar would be nice here, e.g. a string literal like: ``` html`` ``` …but for selectors. Example: ``` const selector = (strings, ...values) => String.raw( { raw: strings }, values.map(value => CSS.escape(value)) ) const fieldName = 'foo#-123'; console.log(selector`foo${fieldName}`) ``` Would output `foofoo\#-123` So we could write: ``` .querySelector(selector`[name="${fieldName}"]`) ``` …and be safe. Suggestions for a nice literal name?
  16. Benjamin Franzke commented on patch set 11 10/19/23, 10:39

    form-engine-validation.ts:89 Reply

  17. Benjamin Franzke rebased onto patch set 12 CR +1 V +1 10/19/23, 12:24

    Rebase Trigger-CI
  18. Benjamin Franzke commented on patch set 12 V +1 CR +1 10/19/23, 12:26

    form-engine-validation.ts:89 Reply

    Will be solved in mentioned patchset.
  19. core-ci voted on patch set 12 V +1 10/19/23, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47941

  20. Andreas Kienast uploaded patch set 13 CR +1 V +1 10/26/23, 08:56

  21. core-ci voted on patch set 13 V +1 10/26/23, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48215

  22. Benjamin Franzke voted on patch set 13 V +1 CR +1 10/26/23, 09:30

  23. Stefan Bürk voted on patch set 13 V +1 CR +1 10/26/23, 21:35

  24. Benjamin Franzke voted on patch set 13 V +2 CR +2 10/27/23, 04:41

  25. Benjamin Franzke merged patch set 14 10/27/23, 04:41