80925[TASK] Clean up `@typo3/backend/form-engine-validation` module
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 8
- Build/Sources/TypeScript/backend/tests/form-engine-validation-test.ts+1 −1
- Build/Sources/TypeScript/backend/form-engine-review.ts+3 −3
- Build/Sources/TypeScript/backend/form-engine-validation.ts7+101 −169
- Build/Sources/TypeScript/backend/form-engine.ts+9 −13
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine-review.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine-validation.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine.js+1 −1
- typo3/sysext/core/Documentation/Changelog/13.0/Deprecation-101912-DeprecatedPassingJQueryObjectsToFormEngineValidation.rstnew+42 −0
Review log 3043
Show 1218 earlier messages
-
Andreas Kienast uploaded patch set 1 09/08/23, 08:09
-
core-ci voted on patch set 1 V -1 09/08/23, 08:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46376
-
Oliver Klee commented on patch set 1 09/08/23, 08:44
Typo: CLeanup -> clean up (with a lowercase “l”, and with a space, as the verb is “to clean up”, while the noun is “the cleanup” -
Andreas Kienast commented on patch set 1 09/08/23, 08:53
Reply
You're aware that you're reviewing a WIP patch that obviously has an incomplete message, right? 😊 -
Andreas Kienast commented on patch set 1 09/08/23, 08:53
Reply
Done -
Andreas Kienast uploaded patch set 2
V -109/08/23, 11:38 -
core-ci voted on patch set 2 V -1 09/08/23, 11:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46382
-
Andreas Kienast uploaded patch set 3
V -109/08/23, 12:14 -
core-ci voted on patch set 3 V -1 09/08/23, 12:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46386
-
Andreas Kienast uploaded patch set 4
V -109/08/23, 12:36 -
core-ci voted on patch set 4 V +1 09/08/23, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46389
-
Andreas Kienast uploaded patch set 5
V +109/08/23, 12:59 -
core-ci voted on patch set 5 V +1 09/08/23, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46394
-
Andreas Kienast uploaded patch set 6
V +109/13/23, 09:47 -
Oliver Klee wrote 09/13/23, 09:51
Removed cc Oliver Klee. -
core-ci voted on patch set 6 V +1 09/13/23, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46534
-
Andreas Kienast uploaded patch set 7
V +109/13/23, 13:19 -
Andreas Kienast commented on patch set 7 CR -1 09/13/23, 13:20
on it
-
core-ci voted on patch set 7 V +1 09/13/23, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46547
-
Andreas Kienast uploaded patch set 8
CR -1V +109/13/23, 13:33 -
core-ci voted on patch set 8 V +1 09/13/23, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46548
-
Benjamin Franzke commented on patch set 8 CR -1 09/14/23, 08:10
form-engine-validation.ts:396as already discussed in person: could be made non breaking using bubbles: true (therefore marking -1 for now, so we do not forget) -
Andreas Kienast uploaded patch set 9
CR -1V +109/14/23, 09:44 -
Andreas Kienast commented on patch set 9 09/14/23, 09:44
form-engine-validation.ts:396ReplyWorks as expected, thanks for the hint. -
core-ci voted on patch set 9 V +1 09/14/23, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46568
-
Benjamin Franzke uploaded patch set 10
V +109/18/23, 12:46 -
core-ci voted on patch set 10 V +1 09/18/23, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46664
-
Andreas Kienast uploaded patch set 11
CR +1V +109/26/23, 12:36 -
core-ci voted on patch set 11 V +1 09/26/23, 12:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47184
-
Stefan Bürk voted on patch set 11 V +1 09/26/23, 13:46
-
Oliver Hader commented on patch set 11 CR +1 10/18/23, 13:38
form-engine-validation.ts:89General question on "constructed DOM queries": Should be use `CSS.escape(fieldName)` instead - would apply to any other dynamic selector-part as well... -
Andreas Kienast commented on patch set 11 10/18/23, 13:50
form-engine-validation.ts:89ReplyIn general this is a good hint. I think this qualifies for a separate bugfix down to v11, right? -
Benjamin Franzke commented on patch set 11 10/19/23, 08:37
form-engine-validation.ts:89ReplyAck. I think some syntax sugar would be nice here, e.g. a string literal like: ``` html`` ``` …but for selectors. Example: ``` const selector = (strings, ...values) => String.raw( { raw: strings }, values.map(value => CSS.escape(value)) ) const fieldName = 'foo#-123'; console.log(selector`foo${fieldName}`) ``` Would output `foofoo\#-123` So we could write: ``` .querySelector(selector`[name="${fieldName}"]`) ``` …and be safe. Suggestions for a nice literal name? -
Benjamin Franzke commented on patch set 11 10/19/23, 10:39
form-engine-validation.ts:89Reply -
Benjamin Franzke rebased onto patch set 12
CR +1V +110/19/23, 12:24Rebase Trigger-CI -
Benjamin Franzke commented on patch set 12 V +1 CR +1 10/19/23, 12:26
form-engine-validation.ts:89ReplyWill be solved in mentioned patchset. -
core-ci voted on patch set 12 V +1 10/19/23, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47941
-
Andreas Kienast uploaded patch set 13
CR +1V +110/26/23, 08:56 -
core-ci voted on patch set 13 V +1 10/26/23, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48215
-
Benjamin Franzke voted on patch set 13 V +1 CR +1 10/26/23, 09:30
-
Stefan Bürk voted on patch set 13 V +1 CR +1 10/26/23, 21:35
-
Benjamin Franzke voted on patch set 13 V +2 CR +2 10/27/23, 04:41
-
Benjamin Franzke merged patch set 14 10/27/23, 04:41