Review main Merged

80927[TASK] Add `@typo3/backend/utility/dom-helper` module

Andreas Kienast CR +2 V +2 Normal +49 −13 updated 09/12/23, 10:41

Commit message

This patch adds a new module `@typo3/backend/utility/dom-helper` whose
primary use is easing the migration from jQuery in case some native API
is missing. As a start, the module contains a custom implementation to
get all parent elements matching a specific selector.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Nedbal +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Nedbal +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1113

  1. Andreas Kienast uploaded patch set 1 09/08/23, 13:05

  2. core-ci voted on patch set 1 V +1 09/08/23, 13:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46395

  3. Andreas Nedbal voted on patch set 1 V +1 CR +1 09/08/23, 13:35

  4. Benjamin Franzke commented on patch set 1 CR -1 09/11/23, 08:42

    Hm, I have to say i'm not a big fan on this (especially being API). Why? The primary usecase of such operation is probably to toggle some states on the live dom, where elements need to guess parent markup. This case could be either: * ideally be rendered as a component where the filter influences which areas are visible or not * or alternatively (less intrusive) an event on the eleemnts that are supposed to be "shown" could be triggered, where all collapse-containers listen on and show themselves accordingly. What do you think? Too complicated? Maybe, but then please mark it at least `@internal` to not create an own jquery alias ;)
  5. Andreas Kienast commented on patch set 1 09/11/23, 10:05

    Reply

    `@internal` is fine for me. I currently need this in the FormEngine area as well (for the time being), therefore I extracted it into a separate module.
  6. Benjamin Franzke commented on patch set 1 09/11/23, 10:24

    Reply

    Ack
  7. Andreas Kienast commented on patch set 2 CR +1 V +1 09/12/23, 07:15

    Published edit on patch set 1.
  8. Benjamin Franzke voted on patch set 2 CR +1 09/12/23, 07:17

  9. core-ci voted on patch set 2 V +1 09/12/23, 07:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46504

  10. Benjamin Franzke voted on patch set 2 V +1 09/12/23, 08:38

  11. Andreas Nedbal voted on patch set 2 V +1 CR +1 09/12/23, 08:51

  12. Benjamin Franzke voted on patch set 2 V +2 CR +2 09/12/23, 10:15

  13. Benjamin Franzke merged patch set 3 09/12/23, 10:41