Review main Merged

80935[TASK] Apply php-cs-fixer across all php files

Stefan Bürk CR +2 V +2 Normal +102 −102 updated 09/10/23, 05:41

Commit message

php-cs-fixer rules have been changed and only
partially applied yet, also with the recently
merged php-cs-fixer raise and mitigation of a
deprecated rule in #101888. That patch should
have used the `-s cgl` instead of `-s cglGit`
which only scans within php files included in
the very same commit - not applying it across
all files.

This change mitigates this by executing the
php-cs-fixer against all files.

Used command(s):

> Build/Scripts/runTests.sh -s cgl

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 62

Show 42 more files