80939[BUGFIX] Do not try to parse non-strings as XML in DataHandler
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1721
-
Oliver Klee uploaded patch set 1 09/10/23, 12:07
-
core-ci voted on patch set 1 V -1 09/10/23, 12:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46441
-
Oliver Klee uploaded patch set 2
V -109/10/23, 12:31 -
core-ci voted on patch set 2 V +1 09/10/23, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46443
-
Oliver Wand voted on patch set 2 CR +1 09/10/23, 15:44
-
Georg Ringer commented on patch set 2 09/11/23, 06:39
-
Oliver Klee uploaded patch set 3
CR +1V +109/11/23, 08:02 -
Oliver Klee commented on patch set 2 09/11/23, 08:03
DataHandler.php:4118ReplyThanks, true true. :-) Done. -
core-ci voted on patch set 3 V +1 09/11/23, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46463
-
Stefan Bürk voted on patch set 3 V +1 CR +1 09/12/23, 05:25
-
Georg Ringer commented on patch set 3 09/13/23, 05:15
DataHandler.php:4093isn't null also a possible return value? -
Oliver Klee uploaded patch set 4
CR +1V +109/13/23, 07:46 -
Oliver Klee commented on patch set 3 09/13/23, 07:46
DataHandler.php:4093ReplyGood catch - it is indeed! Done. -
core-ci voted on patch set 4 V +1 09/13/23, 07:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46532
-
Georg Ringer voted on patch set 4 V +1 CR +1 09/13/23, 08:07
-
Stefan Bürk commented on patch set 4 09/13/23, 08:27
DataHandler.php:4093ReplyWhy changing the return type adding another type to the soup - instead of using a empty '' as tenary fallback in https://review.typo3.org/c/Packages/TYPO3.CMS/+/80939/3/typo3/sysext/core/Classes/DataHandling/DataHandler.php#4118 ? -
Oliver Klee commented on patch set 4 09/13/23, 08:50
DataHandler.php:4093ReplyI'm not changing the (actual) return type of the method (unless I'm missing something here). This method already returned `null` in some cases, and I'm fixing the return type annotation to match the actual behavior (both with and without this change). (I'd be fine with changing the (actual) return type, but that is out of scope of this change, which is about not calling `GU::xml2array` with `null` and hence avoiding a type error. If you think that we should change this method to never return `null`, could you create a (separate) ticket for that?) -
Christian Kuhn voted on patch set 4 V +1 CR +1 09/18/23, 14:25
-
Stefan Bürk voted on patch set 4 V +1 CR +1 09/18/23, 15:01
-
Stefan Bürk voted on patch set 4 V +2 CR +2 09/18/23, 15:10
-
Stefan Bürk merged patch set 5 09/18/23, 16:26
DataHandler.php:4118