Review main Merged

80948[BUGFIX] Reinitialize ContentObjectRenderer for pages

Georg Ringer CR +2 V +2 Easy +7 −1 updated 05/14/24, 09:40

Commit message

The menu generation must not reuse the page record from the current page
but must use the data from the linked page.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Christoph Lehmann +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Robinson +1
    • Christoph Lehmann +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1823

  1. Georg Ringer uploaded patch set 1 09/11/23, 08:55

  2. Friedemann Altrock commented on patch set 1 09/11/23, 09:04

    AbstractMenuContentObject.php:1662

    Why not call $cObj->createLink() instead of passing $cObj as a parameter? Then it would use $this and that would be the correct cObj.
  3. core-ci voted on patch set 1 V -1 09/11/23, 09:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46470

  4. Georg Ringer uploaded patch set 2 V -1 09/11/23, 12:09

  5. core-ci voted on patch set 2 V -1 09/11/23, 12:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46480

  6. Georg Ringer uploaded patch set 3 V -1 09/12/23, 04:44

  7. core-ci voted on patch set 3 V +1 09/12/23, 04:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46492

  8. Georg Ringer uploaded patch set 4 V +1 10/09/23, 18:33

  9. Georg Ringer commented on patch set 4 10/09/23, 18:33

    AbstractMenuContentObject.php:1662 Reply

    Done
  10. Georg Ringer commented on patch set 4 10/09/23, 18:34

    This change is ready for review.
  11. core-ci voted on patch set 4 V +1 10/09/23, 18:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47620

  12. Christoph Lehmann commented on patch set 4 V +1 CR +1 10/29/23, 20:55

    Good catch!
  13. Oliver Klee voted on patch set 4 CR +1 10/29/23, 23:07

  14. Benjamin Robinson voted on patch set 4 V +1 03/26/24, 09:47

  15. Georg Ringer rebased onto patch set 5 CR +1 V +1 03/29/24, 10:02

  16. core-ci voted on patch set 5 V +1 03/29/24, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55058

  17. Oliver Klee voted on patch set 5 CR +1 03/29/24, 11:59

  18. Benni Mack voted on patch set 5 CR +1 V +1 03/29/24, 21:43

  19. Benjamin Robinson voted on patch set 5 V +1 04/03/24, 08:32

  20. Christoph Lehmann voted on patch set 5 CR +1 V +1 04/03/24, 08:54

  21. Benni Mack voted on patch set 5 CR +2 V +2 04/03/24, 09:12

  22. Benni Mack merged patch set 6 04/03/24, 09:12

  23. Oliver Hader commented on patch set 6 05/14/24, 09:40

    Unresolved