80950[TASK] Let enum reconstitution in CSP ModelService fail early
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Georg Ringer +1
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Oliver Hader +2
- Georg Ringer +1
- Oliver Klee +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1115
-
Oliver Hader uploaded patch set 1 09/11/23, 11:09
-
Oliver Hader uploaded patch set 2 09/11/23, 11:13
-
core-ci voted on patch set 1 V -1 09/11/23, 11:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46475
-
core-ci voted on patch set 2 V -1 09/11/23, 11:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46476
-
Lina Wolf commented on patch set 2 CR +1 09/11/23, 13:42
I love it, even with tests! However it seems like CI is not happy yet -
Oliver Hader uploaded patch set 3
CR +1V -109/11/23, 15:03 -
Oliver Hader commented on patch set 3 09/11/23, 15:04
Seems like PHP 8.3 changed the ValueError message format... -
core-ci voted on patch set 3 V -1 09/11/23, 15:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46482
-
Oliver Hader uploaded patch set 4
V -109/11/23, 16:03 -
core-ci voted on patch set 4 V +1 09/11/23, 16:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46483
-
Georg Ringer voted on patch set 4 V +1 CR +1 09/11/23, 20:28
-
Stefan Bürk voted on patch set 4 V +1 CR +1 09/12/23, 04:59
-
Oliver Klee voted on patch set 4 V +1 CR +1 09/12/23, 06:06
-
Oliver Hader voted on patch set 4 V +2 CR +2 09/12/23, 07:55
-
Oliver Hader merged patch set 5 09/12/23, 08:00