Review main Merged

80950[TASK] Let enum reconstitution in CSP ModelService fail early

Oliver Hader CR +2 V +2 Easy +47 −2 updated 09/12/23, 08:00

Commit message

Reconstituting CSP from string in class `ModelService` falls back
to `null` values in case of using invalid backing values for the
enums `MutationMode` or `Directive`.
This changes uses `[enum]::from()` instead of `[enum]::tryFrom()`,
that causes the process to fail early with a better error message.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1115

  1. Oliver Hader uploaded patch set 1 09/11/23, 11:09

  2. Oliver Hader uploaded patch set 2 09/11/23, 11:13

  3. core-ci voted on patch set 1 V -1 09/11/23, 11:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46475

  4. core-ci voted on patch set 2 V -1 09/11/23, 11:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46476

  5. Lina Wolf commented on patch set 2 CR +1 09/11/23, 13:42

    I love it, even with tests! However it seems like CI is not happy yet
  6. Oliver Hader uploaded patch set 3 CR +1 V -1 09/11/23, 15:03

  7. Oliver Hader commented on patch set 3 09/11/23, 15:04

    Seems like PHP 8.3 changed the ValueError message format...
  8. core-ci voted on patch set 3 V -1 09/11/23, 15:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46482

  9. Oliver Hader uploaded patch set 4 V -1 09/11/23, 16:03

  10. core-ci voted on patch set 4 V +1 09/11/23, 16:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46483

  11. Georg Ringer voted on patch set 4 V +1 CR +1 09/11/23, 20:28

  12. Stefan Bürk voted on patch set 4 V +1 CR +1 09/12/23, 04:59

  13. Oliver Klee voted on patch set 4 V +1 CR +1 09/12/23, 06:06

  14. Oliver Hader voted on patch set 4 V +2 CR +2 09/12/23, 07:55

  15. Oliver Hader merged patch set 5 09/12/23, 08:00