Review 12.4 Merged

80979[TASK] Let enum reconstitution in CSP ModelService fail early

Oliver Hader CR +2 V +2 Easy +47 −2 updated 09/12/23, 08:00

Commit message

Reconstituting CSP from string in class `ModelService` falls back
to `null` values in case of using invalid backing values for the
enums `MutationMode` or `Directive`.
This changes uses `[enum]::from()` instead of `[enum]::tryFrom()`,
that causes the process to fail early with a better error message.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Oliver Hader uploaded patch set 1 09/12/23, 07:40

  2. core-ci voted on patch set 1 V +1 09/12/23, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46506

  3. Oliver Hader voted on patch set 1 V +2 CR +2 09/12/23, 07:55

  4. Oliver Hader merged patch set 2 09/12/23, 08:00