Review main Merged

80980[BUGFIX] Correct RTL handling of scaffold

Benjamin Kott CR +2 V +2 Normal +108 −43 updated 09/13/23, 06:38

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 911

  1. Benjamin Kott uploaded patch set 1 09/12/23, 08:22

  2. core-ci voted on patch set 1 V +1 09/12/23, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46507

  3. Benjamin Kott commented on patch set 1 09/12/23, 08:36

    for easy testing `document.querySelector('html').setAttribute('dir', 'rtl');`
  4. Benjamin Franzke voted on patch set 1 V +1 CR +1 09/12/23, 08:42

  5. Benni Mack voted on patch set 1 CR +1 09/12/23, 08:42

  6. Benjamin Kott rebased onto patch set 2 CR +1 V +1 09/12/23, 14:31

  7. core-ci voted on patch set 2 V +1 09/12/23, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46522

  8. Benjamin Franzke voted on patch set 2 V +1 CR +1 09/12/23, 14:48

  9. Georg Ringer voted on patch set 2 V +1 CR +1 09/13/23, 05:12

  10. Benjamin Franzke voted on patch set 2 V +2 CR +2 09/13/23, 06:09

  11. Benjamin Franzke merged patch set 3 09/13/23, 06:38