80983[BUGFIX] Avoid redirect loop for empty redirect url
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Rafael Kähm +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Rafael Kähm +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 1
Review log 2228
Show 23 earlier messages
-
Stefan Bürk uploaded patch set 1 09/12/23, 12:35
-
Stefan Bürk updated the commit message in patch set 2 09/12/23, 12:40
-
core-ci voted on patch set 1 V +1 09/12/23, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46515
-
Stefan Bürk updated the commit message in patch set 3 09/12/23, 12:43
-
core-ci voted on patch set 2 V +1 09/12/23, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46516
-
Stefan Bürk updated the commit message in patch set 4 09/12/23, 12:51
-
core-ci voted on patch set 3 V +1 09/12/23, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46517
-
core-ci voted on patch set 4 V +1 09/12/23, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46518
-
Oliver Klee voted on patch set 4 CR +1 09/12/23, 13:21
-
Stefan Bürk rebased onto patch set 5
CR +1V +109/20/23, 14:49 -
Oliver Klee voted on patch set 5 CR +1 09/20/23, 14:51
-
core-ci voted on patch set 5 V +1 09/20/23, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46902
-
Rafael Kähm commented on patch set 5 V +1 CR +1 09/21/23, 06:12
Thanks for fixing that issue. -
Thomas Hohn voted on patch set 5 CR +1 09/22/23, 16:20
-
Simon Schaufelberger commented on patch set 5 09/27/23, 15:22
I suggest to install/activate a spellcheck ;)an endlessan additional -
Stefan Bürk updated the commit message in patch set 6
CR +1V +109/27/23, 15:43 -
Stefan Bürk commented on patch set 6 09/27/23, 15:44
Reply
Not aware of one for the cli.Reply
DoneReply
Done -
core-ci voted on patch set 6 V +1 09/27/23, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47256
-
Oliver Klee voted on patch set 6 CR +1 09/27/23, 16:03
-
Simon Schaufelberger commented on patch set 6 09/27/23, 16:11
Reply
ah ok, I always use phpstorm to commit as well. I also use the https://plugins.jetbrains.com/plugin/7272-gerrit plugin The only downside is that I can't use github source with it so fetching data is slow. -
Benni Mack voted on patch set 6 V +1 CR +1 09/27/23, 16:47
-
Benjamin Franzke commented on patch set 6 09/27/23, 18:21
How can this be reproduced? You stated in https://forge.typo3.org/issues/100791#note-6 that you are not able to reproduce the issue, so, how did you manage to do so in the meantime? -
Benni Mack commented on patch set 6 09/27/23, 18:23
with a wrong entry in sys_redirects -
Stefan Bürk commented on patch set 6 09/27/23, 18:38
Reply
main + 12 is as safety guard, in 11 it's easy: * v11 mono repo * install styleguide -> frontend demo page tree * change the base of the frontend demo site configuration from `/styleguide-demo-*` to `/` without a domain, only the slash. * create a sys_redirect record, can be done in over the gui: normal (not regexp) redirect, for source_path simply enter a random not existing path, e.g "/some/path/which/does/not/exists/" and as target simply enter a "/" into the input field (not using the link browser or something like that) and save the record. * Open "https://monorepo.tld/some/path/which/does/not/exists/" IN chrome, simply nothing happens and you get a simple white page. Using firefox you can see in the network tap several redirects until it stops with the redirect loop info. main/v12 is fixed with our changes regarding the link handling and legacy linkbuilder stuff handling "folder => url" which we discussed and have done during the last community sprint. Talked with Benni, that was quite some changes not easily backportable to v11. Therefore, I decided to add this safety guard - and also to main/12.4 - to mitigate if with some changes in the future and a emtpy redirect url would be generated, eventuall by some events and so on, we have this safety net and don't handle it (ending in a 404 instead). If I was to unclear, ping me on slack and I can show you it in a screen share or add screenshots to the issue. -
Stefan Bürk commented on patch set 6 09/27/23, 18:43
Reply
Not tested with a directly added record to the table with a empty target - "/" should not lead to it in v12+. -
Rafael Kähm voted on patch set 6 V +1 CR +1 09/28/23, 06:25
-
Stefan Bürk voted on patch set 6 V +2 CR +2 09/28/23, 09:07
-
Stefan Bürk merged patch set 7 09/28/23, 09:22