Review main Merged

81012[TASK] Load CKEditor5 modules from their package entry points

Benjamin Franzke CR +2 V +2 Nightmare +2083 −2055 updated 09/18/23, 08:25

Commit message

Make sure that all imports are from the package entry point
instead of the path to a module as suggested by upstream:
https://ckeditor.com/docs/ckeditor5/latest/updating/guides/update-to-37.html

Note: `LinkActionsView` still needs to be imported from
`@ckeditor/ckeditor5-link/src/ui/linkactionsview.js` and
`LinkUtils` from `@ckeditor/ckeditor5-link/src/utils.js`
as they are not exported as named exports on the package
entry points.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Nedbal +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Nedbal +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 710

  1. Benjamin Franzke uploaded patch set 1 09/13/23, 11:14

  2. core-ci voted on patch set 1 V -1 09/13/23, 11:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46539

  3. Benjamin Franzke uploaded patch set 2 V -1 09/14/23, 06:56

  4. core-ci voted on patch set 2 V +1 09/14/23, 07:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46560

  5. Benjamin Franzke updated the commit message in patch set 3 V +1 09/14/23, 07:41

  6. core-ci voted on patch set 3 V +1 09/14/23, 07:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46564

  7. Andreas Kienast voted on patch set 3 V +1 CR +1 09/14/23, 11:50

  8. Andreas Nedbal voted on patch set 3 V +1 CR +1 09/15/23, 20:49

  9. Benjamin Franzke voted on patch set 3 V +2 CR +2 09/18/23, 08:00

  10. Benjamin Franzke merged patch set 4 09/18/23, 08:25