Review main Merged

81016[FEATURE] Auto DB fields from TCA for type "imageManipulation"

Anja Leichsenring CR +2 V +2 Easy +39 −1 updated 07/31/24, 18:20

Commit message

Tables with TCA columns set to type="imageManipulation" do not
need an ext_tables.sql entry anymore. The core now
creates this field automatically.

This is one of many patches in this area: The v13 goal
is to obsolete ext_tables.sql in most cases by
creating default "business" fields of TCA tables
automatically.

The patch adds the main magic in class DefaultTcaSchema
and removes own ext_tables.sql definitions having
type=imageManipulation.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1

Issues 2

Files 4

Review log 79

  1. Anja Leichsenring uploaded patch set 1 09/14/23, 03:37

  2. core-ci voted on patch set 1 V +1 09/14/23, 03:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46556

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 09/18/23, 06:21

  4. Christian Kuhn uploaded patch set 2 CR +1 V +1 09/18/23, 17:26

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 09/18/23, 17:26

  6. Stefan Bürk voted on patch set 2 V +2 CR +2 09/18/23, 17:34

  7. Stefan Bürk merged patch set 3 09/18/23, 17:34

  8. core-ci voted on patch set 2 V +1 09/18/23, 17:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46696

  9. Oli Bartsch commented on patch set 3 09/18/23, 18:02

    DefaultTcaSchema.php:635 Unresolved

    Not a file field.