81022[TASK] Suggest PHP exif module in system environment status
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Guido Schmechel +1
- Garvin Hicking +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Stefan Bürk +2
- Guido Schmechel +1
- Garvin Hicking +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 4
Review log 2229
Show 24 earlier messages
-
Torben Hansen uploaded patch set 1 09/14/23, 17:54
-
core-ci voted on patch set 1 V -1 09/14/23, 18:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46581
-
Torben Hansen updated the commit message in patch set 2
V -109/15/23, 05:49 -
core-ci voted on patch set 2 V -1 09/15/23, 05:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46587
-
Garvin Hicking commented on patch set 2 V +1 CR +1 09/15/23, 07:26
Good addition! 😊 -
Simon Schaufelberger commented on patch set 2 09/15/23, 07:35
I would also add it to composer.json to the suggest block -
Torben Hansen uploaded patch set 3
CR +1V +109/15/23, 08:02 -
Georg Ringer commented on patch set 3 09/15/23, 08:04
and also backport that to v12 -
Torben Hansen commented on patch set 3 09/15/23, 08:05
Reply
I also added ext-exif to composer json and kept the suggestion in system environment check for users not using composer. -
Garvin Hicking voted on patch set 3 V +1 CR +1 09/15/23, 08:06
-
Stefan Bürk commented on patch set 3 CR -1 09/15/23, 08:06
Looking into getting the `exif` module into the php image and verify that there are no side effects. -
core-ci voted on patch set 3 V -1 09/15/23, 08:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46589
-
Simon Schaufelberger commented on patch set 3 09/15/23, 08:12
composer.json:130I would also add it to the extension specific composer.json -
Torben Hansen uploaded patch set 4
CR +1V +109/15/23, 08:17 -
Torben Hansen commented on patch set 4 09/15/23, 08:18
composer.json:130ReplyDone -
core-ci voted on patch set 4 V -1 09/15/23, 08:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46592
-
core-ci voted on patch set 4 V +1 09/15/23, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46592
-
Stefan Bürk commented on patch set 4 09/15/23, 09:45
Reply
Done -
Guido Schmechel voted on patch set 4 V +1 CR +1 09/15/23, 19:55
-
Simon Schaufelberger uploaded patch set 5
CR +1V +109/16/23, 08:47 -
Simon Schaufelberger uploaded patch set 6 09/16/23, 08:49
-
Simon Schaufelberger commented on patch set 6 09/16/23, 08:50
just sorted the list alphabetically -
Simon Schaufelberger voted on patch set 6 V +1 CR +1 09/16/23, 08:51
-
core-ci voted on patch set 5 V +1 09/16/23, 08:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46621
-
core-ci voted on patch set 6 V +1 09/16/23, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46622
-
Garvin Hicking voted on patch set 6 V +1 CR +1 09/16/23, 12:31
-
Guido Schmechel voted on patch set 6 V +1 CR +1 09/16/23, 17:23
-
Stefan Bürk voted on patch set 6 V +2 CR +2 09/18/23, 06:00
-
Stefan Bürk merged patch set 7 09/18/23, 06:00