Review main Merged

81022[TASK] Suggest PHP exif module in system environment status

Torben Hansen CR +2 V +2 Easy +7 −3 updated 09/18/23, 06:00

Commit message

If the PHP exif module is installed, TYPO3 uses the `exif_read_data()`
function of read exif metadata of images. In case of the image upload
functionality in TYPO3, the `exif_read_data()` function is used to
evaluate the `Orientation` exif property, which is used to decide, if
the width and height of an image should be switched before the data
is saved in the `sys_file_metadata` table. If the PHP exif module is
not available, portrait images created by modern camera systems might
be saved with wrong width and height, because the exif `Orientation`
is not respected. This might result in rending of distorted images,
when the uploaded image is processed by TYPO3 image rendering.

With this change, the system environment check is extended to
suggest to PHP exif module to be installed. If not available,
a warning message is shown in the system environment check.
Additionally, composer.json files of system extensions using
exif related functions (is available) have been updated to
suggest PHP ext-exif.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Guido Schmechel +1
    • Garvin Hicking +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Guido Schmechel +1
    • Garvin Hicking +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 2229

Show 24 earlier messages
  1. Torben Hansen uploaded patch set 1 09/14/23, 17:54

  2. core-ci voted on patch set 1 V -1 09/14/23, 18:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46581

  3. Torben Hansen updated the commit message in patch set 2 V -1 09/15/23, 05:49

  4. core-ci voted on patch set 2 V -1 09/15/23, 05:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46587

  1. Garvin Hicking commented on patch set 2 V +1 CR +1 09/15/23, 07:26

    Good addition! 😊
  2. Simon Schaufelberger commented on patch set 2 09/15/23, 07:35

    I would also add it to composer.json to the suggest block
  3. Torben Hansen uploaded patch set 3 CR +1 V +1 09/15/23, 08:02

  4. Georg Ringer commented on patch set 3 09/15/23, 08:04

    and also backport that to v12
  5. Torben Hansen commented on patch set 3 09/15/23, 08:05

    Reply

    I also added ext-exif to composer json and kept the suggestion in system environment check for users not using composer.
  6. Garvin Hicking voted on patch set 3 V +1 CR +1 09/15/23, 08:06

  7. Stefan Bürk commented on patch set 3 CR -1 09/15/23, 08:06

    Looking into getting the `exif` module into the php image and verify that there are no side effects.
  8. core-ci voted on patch set 3 V -1 09/15/23, 08:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46589

  9. Simon Schaufelberger commented on patch set 3 09/15/23, 08:12

    composer.json:130

    I would also add it to the extension specific composer.json
  10. Torben Hansen uploaded patch set 4 CR +1 V +1 09/15/23, 08:17

  11. Torben Hansen commented on patch set 4 09/15/23, 08:18

    composer.json:130 Reply

    Done
  12. core-ci voted on patch set 4 V -1 09/15/23, 08:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46592

  13. core-ci voted on patch set 4 V +1 09/15/23, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46592

  14. Stefan Bürk commented on patch set 4 09/15/23, 09:45

    Reply

    Done
  15. Guido Schmechel voted on patch set 4 V +1 CR +1 09/15/23, 19:55

  16. Simon Schaufelberger uploaded patch set 5 CR +1 V +1 09/16/23, 08:47

  17. Simon Schaufelberger uploaded patch set 6 09/16/23, 08:49

  18. Simon Schaufelberger commented on patch set 6 09/16/23, 08:50

    just sorted the list alphabetically
  19. Simon Schaufelberger voted on patch set 6 V +1 CR +1 09/16/23, 08:51

  20. core-ci voted on patch set 5 V +1 09/16/23, 08:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46621

  21. core-ci voted on patch set 6 V +1 09/16/23, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46622

  22. Garvin Hicking voted on patch set 6 V +1 CR +1 09/16/23, 12:31

  23. Guido Schmechel voted on patch set 6 V +1 CR +1 09/16/23, 17:23

  24. Stefan Bürk voted on patch set 6 V +2 CR +2 09/18/23, 06:00

  25. Stefan Bürk merged patch set 7 09/18/23, 06:00