Review main Merged

81024[BUGFIX] Handle FileDoesNotExistException in `cleanup:missingrelations`

Benjamin Serfhos CR +2 V +2 Easy +24 −16 updated 09/20/23, 22:36

Commit message

It's possible that file references to files exists, where
the physical file is missing. That stopped further file
reference processing in the ext:lowlevel cleanup command
`cleanup:missingrelations`.

Therefore, this change explicitly catches the concrete
`\TYPO3\CMS\Core\Resource\Exception\FileDoesNotExistException`
exception and outputs the message, without interrupting the
processing of further files.

The handling code is moved to a dedicated method to clean
up code duplication on the same step as a side-change.

Other unforeseen errors still stop the execution.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1420

  1. Benjamin Serfhos uploaded patch set 1 09/15/23, 08:06

  2. Benjamin Serfhos uploaded patch set 2 09/15/23, 08:09

  3. core-ci voted on patch set 1 V +1 09/15/23, 08:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46590

  4. core-ci voted on patch set 2 V +1 09/15/23, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46591

  5. Stefan Bürk updated the commit message in patch set 3 V +1 09/20/23, 19:40

  6. Stefan Bürk commented on patch set 3 CR -1 09/20/23, 19:48

    on it ...
    We should rephrase the commit message a bit and add some description to it.

    MissingRelationsCommand.php:372

    This is "too broad" - we should make this concrete here and only catch the `\TYPO3\CMS\Core\Resource\Exception\FileDoesNotExistException` here. Other issues and exception may indicate other things, so a stop is better for now until we now how to deal with it.
  7. core-ci voted on patch set 3 V +1 09/20/23, 19:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46924

  8. Stefan Bürk uploaded patch set 4 CR -1 V +1 09/20/23, 20:02

  9. Stefan Bürk updated the commit message in patch set 5 09/20/23, 20:03

  10. Stefan Bürk commented on patch set 5 V +1 CR +1 09/20/23, 20:03

    Reply

    Done

    Reply

    Done

    MissingRelationsCommand.php:372 Reply

    Done
  11. core-ci voted on patch set 4 V +1 09/20/23, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46926

  12. Oliver Klee voted on patch set 5 CR +1 09/20/23, 20:10

  13. core-ci voted on patch set 5 V +1 09/20/23, 20:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46927

  14. Oli Bartsch updated the commit message in patch set 6 CR +1 V +1 09/20/23, 20:31

  15. core-ci voted on patch set 6 V +1 09/20/23, 20:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46928

  16. Oliver Klee voted on patch set 6 CR +1 09/20/23, 20:58

  17. Stefan Bürk voted on patch set 6 V +1 CR +1 09/20/23, 21:01

  18. Benni Mack voted on patch set 6 V +1 CR +1 09/20/23, 22:15

  19. Benni Mack voted on patch set 6 V +2 CR +2 09/20/23, 22:36

  20. Benni Mack merged patch set 7 09/20/23, 22:36