81024[BUGFIX] Handle FileDoesNotExistException in `cleanup:missingrelations`
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1420
-
Benjamin Serfhos uploaded patch set 1 09/15/23, 08:06
-
Benjamin Serfhos uploaded patch set 2 09/15/23, 08:09
-
core-ci voted on patch set 1 V +1 09/15/23, 08:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46590
-
core-ci voted on patch set 2 V +1 09/15/23, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46591
-
Stefan Bürk updated the commit message in patch set 3
V +109/20/23, 19:40 -
Stefan Bürk commented on patch set 3 CR -1 09/20/23, 19:48
on it ...We should rephrase the commit message a bit and add some description to it.MissingRelationsCommand.php:372This is "too broad" - we should make this concrete here and only catch the `\TYPO3\CMS\Core\Resource\Exception\FileDoesNotExistException` here. Other issues and exception may indicate other things, so a stop is better for now until we now how to deal with it. -
core-ci voted on patch set 3 V +1 09/20/23, 19:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46924
-
Stefan Bürk uploaded patch set 4
CR -1V +109/20/23, 20:02 -
Stefan Bürk updated the commit message in patch set 5 09/20/23, 20:03
-
Stefan Bürk commented on patch set 5 V +1 CR +1 09/20/23, 20:03
Reply
DoneReply
DoneMissingRelationsCommand.php:372ReplyDone -
core-ci voted on patch set 4 V +1 09/20/23, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46926
-
Oliver Klee voted on patch set 5 CR +1 09/20/23, 20:10
-
core-ci voted on patch set 5 V +1 09/20/23, 20:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46927
-
Oli Bartsch updated the commit message in patch set 6
CR +1V +109/20/23, 20:31 -
core-ci voted on patch set 6 V +1 09/20/23, 20:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46928
-
Oliver Klee voted on patch set 6 CR +1 09/20/23, 20:58
-
Stefan Bürk voted on patch set 6 V +1 CR +1 09/20/23, 21:01
-
Benni Mack voted on patch set 6 V +1 CR +1 09/20/23, 22:15
-
Benni Mack voted on patch set 6 V +2 CR +2 09/20/23, 22:36
-
Benni Mack merged patch set 7 09/20/23, 22:36