81026[BUGFIX] Allow change of metadata if file is deleted
Commit message
Review
-
Code review CR 0
-
Verified V -1
- core-ci -1 CI
Issues 2
Files 2
Review log 2132
Show 47 earlier messages
-
Benjamin Serfhos uploaded patch set 1 09/15/23, 08:28
-
core-ci voted on patch set 1 V +1 09/15/23, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46594
-
Benjamin Serfhos uploaded patch set 2
V +109/15/23, 09:28 -
Benjamin Serfhos uploaded patch set 3 09/15/23, 09:30
-
Benjamin Serfhos uploaded patch set 4 09/15/23, 09:30
-
core-ci voted on patch set 3 V -1 09/15/23, 09:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46597
-
core-ci voted on patch set 2 V -1 09/15/23, 09:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46596
-
core-ci voted on patch set 4 V -1 09/15/23, 09:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46598
-
Benjamin Serfhos uploaded patch set 5
V -109/15/23, 10:12 -
core-ci voted on patch set 5 V -1 09/15/23, 10:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46602
-
Benjamin Serfhos uploaded patch set 6
V -109/15/23, 10:31 -
core-ci voted on patch set 6 V +1 09/15/23, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46603
-
Benjamin Serfhos commented on patch set 6 V +1 CR +1 09/15/23, 10:41
I don't know if a test was needed for this bugfix but noticed this functionality was not yet tested. Added 1 'happy flow' test and two expected 'failure' tests including this specific exception throw. -
Stefan Bürk commented on patch set 6 CR -1 09/20/23, 22:58
Reused issue number. Needs a new one. @Benjamin Serfhos Voting on the own patch is discouraged unless someone has rewrote your orignally change drastically.Unresolved
This issue is "already" resolved with https://review.typo3.org/c/Packages/TYPO3.CMS/+/81139 If this change is needed, a new issue needs to be created with a corresponding description why. The "shared" issue number may be added as related. That should also explained in one or two sentences in the commit message. -
Simon Schaufelberger uploaded patch set 7
CR +1V +111/03/23, 14:25 -
Simon Schaufelberger commented on patch set 7 11/03/23, 14:25
Reply
Done -
core-ci voted on patch set 7 V +1 11/03/23, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48550
-
Simon Schaufelberger rebased onto patch set 8
V +111/30/23, 13:01 -
core-ci voted on patch set 8 V +1 11/30/23, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50167
-
Oliver Hader updated the commit message in patch set 9
V +110/18/24, 14:08 -
Benni Mack commented on patch set 9 04/11/25, 20:47
Pinging here, if the change is still needed? -
Benni Mack uploaded patch set 10 04/11/25, 20:52
-
core-ci voted on patch set 10 V +1 04/11/25, 20:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77578
-
Benni Mack commented on patch set 10 04/12/25, 10:38
Reply
Also, @simonschaufi+typo3@gmail.com I'm curious to know how to reproduce this? The ticket doesn't deliver any information here. -
Benni Mack updated the commit message in patch set 11
V +104/12/25, 12:35 -
core-ci voted on patch set 11 V +1 04/12/25, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77619
-
Simon Schaufelberger commented on patch set 11 04/13/25, 15:01
Reply
I just created a new ticket because before a different forge ticket number was mis-used. Better get in touch with @serfhos@gmail.com -
Benni Mack commented on patch set 11 04/13/25, 15:15
Reply Unresolved
Thanks for the feedback @simonschaufi+typo3@gmail.com. OK @serfhos@gmail.com then please let us know how to proceed. I would either like to reproduce this issue in real life so I can verify this or we close review + issue. -
Benni Mack wrote 04/21/26, 14:58
Removed cc Benni Mack. -
Benni Mack updated the commit message in patch set 12
V +104/22/26, 06:48 -
core-ci voted on patch set 12 V -1 04/22/26, 11:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100801
-
Benni Mack abandoned the change 10/09/26, 16:29
closing this change now after 18 months of waiting.