Review main Abandoned

81026[BUGFIX] Allow change of metadata if file is deleted

Benjamin Serfhos CR 0 V -1 Normal +150 −2 updated 10/09/26, 16:29

Commit message

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 2

Files 2

Review log 2132

Show 47 earlier messages
  1. Benjamin Serfhos uploaded patch set 1 09/15/23, 08:28

  2. core-ci voted on patch set 1 V +1 09/15/23, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46594

  3. Benjamin Serfhos uploaded patch set 2 V +1 09/15/23, 09:28

  4. Benjamin Serfhos uploaded patch set 3 09/15/23, 09:30

  5. Benjamin Serfhos uploaded patch set 4 09/15/23, 09:30

  6. core-ci voted on patch set 3 V -1 09/15/23, 09:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46597

  7. core-ci voted on patch set 2 V -1 09/15/23, 09:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46596

  1. core-ci voted on patch set 4 V -1 09/15/23, 09:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46598

  2. Benjamin Serfhos uploaded patch set 5 V -1 09/15/23, 10:12

  3. core-ci voted on patch set 5 V -1 09/15/23, 10:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46602

  4. Benjamin Serfhos uploaded patch set 6 V -1 09/15/23, 10:31

  5. core-ci voted on patch set 6 V +1 09/15/23, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46603

  6. Benjamin Serfhos commented on patch set 6 V +1 CR +1 09/15/23, 10:41

    I don't know if a test was needed for this bugfix but noticed this functionality was not yet tested. Added 1 'happy flow' test and two expected 'failure' tests including this specific exception throw.
  7. Stefan Bürk commented on patch set 6 CR -1 09/20/23, 22:58

    Reused issue number. Needs a new one. @Benjamin Serfhos Voting on the own patch is discouraged unless someone has rewrote your orignally change drastically.

    Unresolved

    This issue is "already" resolved with https://review.typo3.org/c/Packages/TYPO3.CMS/+/81139 If this change is needed, a new issue needs to be created with a corresponding description why. The "shared" issue number may be added as related. That should also explained in one or two sentences in the commit message.
  8. Simon Schaufelberger uploaded patch set 7 CR +1 V +1 11/03/23, 14:25

  9. Simon Schaufelberger commented on patch set 7 11/03/23, 14:25

    Reply

    Done
  10. core-ci voted on patch set 7 V +1 11/03/23, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48550

  11. Simon Schaufelberger rebased onto patch set 8 V +1 11/30/23, 13:01

  12. core-ci voted on patch set 8 V +1 11/30/23, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50167

  13. Oliver Hader updated the commit message in patch set 9 V +1 10/18/24, 14:08

  14. Benni Mack commented on patch set 9 04/11/25, 20:47

    Pinging here, if the change is still needed?
  15. Benni Mack uploaded patch set 10 04/11/25, 20:52

  16. core-ci voted on patch set 10 V +1 04/11/25, 20:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77578

  17. Benni Mack commented on patch set 10 04/12/25, 10:38

    Reply

    Also, @simonschaufi+typo3@gmail.com I'm curious to know how to reproduce this? The ticket doesn't deliver any information here.
  18. Benni Mack updated the commit message in patch set 11 V +1 04/12/25, 12:35

  19. core-ci voted on patch set 11 V +1 04/12/25, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77619

  20. Simon Schaufelberger commented on patch set 11 04/13/25, 15:01

    Reply

    I just created a new ticket because before a different forge ticket number was mis-used. Better get in touch with @serfhos@gmail.com
  21. Benni Mack commented on patch set 11 04/13/25, 15:15

    Reply Unresolved

    Thanks for the feedback @simonschaufi+typo3@gmail.com. OK @serfhos@gmail.com then please let us know how to proceed. I would either like to reproduce this issue in real life so I can verify this or we close review + issue.
  22. Benni Mack wrote 04/21/26, 14:58

    Removed cc Benni Mack.
  23. Benni Mack updated the commit message in patch set 12 V +1 04/22/26, 06:48

  24. core-ci voted on patch set 12 V -1 04/22/26, 11:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100801

  25. Benni Mack abandoned the change 10/09/26, 16:29

    closing this change now after 18 months of waiting.