Review main Merged

81034[TASK] Add tests for ContentObjectRenderer::listNum

Sybille Peters CR +2 V +2 Normal +62 −10 updated 09/18/23, 12:13

Commit message

- Add unit tests for function ContentObjectRenderer::listNum()
- Improve code by renaming function argument ($char => $delimeter)
- Make sure arguments are always passed as strings (and not null)
  (as declared in PHPDoc)
- Improve clarity of description in PHPDoc

In the future typehints can be added for function arguments and
return type.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Sybille Peters uploaded patch set 1 09/17/23, 12:20

  2. core-ci voted on patch set 1 V +1 09/17/23, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46631

  3. Stefan Bürk updated the commit message in patch set 2 V +1 09/18/23, 11:21

  4. Stefan Bürk voted on patch set 2 V +1 CR +1 09/18/23, 11:21

  5. core-ci voted on patch set 2 V +1 09/18/23, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46657

  6. Benni Mack voted on patch set 2 V +2 CR +2 09/18/23, 11:55

  7. Benni Mack merged patch set 3 09/18/23, 11:55

  8. Göran Bodenschatz commented on patch set 3 09/18/23, 12:10

    There's a repeated typo in description and code. It's called delimiter not delimeter. :)