Review 12.4 Merged

81036[TASK] Load CKEditor5 modules from their package entry points

Benjamin Franzke CR +2 V +2 Nightmare +2083 −2055 updated 09/18/23, 08:25

Commit message

Make sure that all imports are from the package entry point
instead of the path to a module as suggested by upstream:
https://ckeditor.com/docs/ckeditor5/latest/updating/guides/update-to-37.html

Note: `LinkActionsView` still needs to be imported from
`@ckeditor/ckeditor5-link/src/ui/linkactionsview.js` and
`LinkUtils` from `@ckeditor/ckeditor5-link/src/utils.js`
as they are not exported as named exports on the package
entry points.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3