81041[TASK] Introduce types in LocalDriver / FAL
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
- Oliver Klee +1
- Andreas Kienast +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2734
Show 69 earlier messages
-
Benni Mack uploaded patch set 1 09/18/23, 11:03
-
core-ci voted on patch set 1 V -1 09/18/23, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46655
-
Oliver Klee commented on patch set 1 09/18/23, 13:33
-
Göran Bodenschatz commented on patch set 1 09/18/23, 14:00
LocalDriver.php:134`* Calculates the absolute path to this driver's storage location.`LocalDriver.php:855`* The responsibility of this method in the Driver is only about an intra-storage move action,`LocalDriver.php:876`* @return array<non-empty-string, non-empty-string>`LocalDriver.php:915`* @return array<non-empty-string, non-empty-string>` -
Benni Mack uploaded patch set 2
V -109/18/23, 16:50 -
Oliver Klee commented on patch set 2 09/18/23, 17:05
LocalDriver.php:65This should work without the quotes. -
core-ci voted on patch set 2 V -1 09/18/23, 17:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46691
-
Benni Mack uploaded patch set 3
V -109/18/23, 20:07 -
core-ci voted on patch set 3 V -1 09/18/23, 20:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46710
-
Benni Mack uploaded patch set 4
V -109/18/23, 20:41 -
core-ci voted on patch set 4 V -1 09/18/23, 20:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46713
-
Benni Mack uploaded patch set 5
V -109/18/23, 21:00 -
core-ci voted on patch set 5 V +1 09/18/23, 21:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46715
-
Oliver Klee commented on patch set 5 09/19/23, 07:38
LocalDriver.php:64ReplyDoneLocalDriver.php:65ReplyDone -
Göran Bodenschatz commented on patch set 5 CR +1 09/19/23, 08:33
LocalDriver.php:134ReplyDoneLocalDriver.php:855ReplyDoneLocalDriver.php:876ReplyDoneLocalDriver.php:915ReplyDone -
Andreas Kienast voted on patch set 5 CR +1 09/19/23, 09:15
-
Oliver Klee voted on patch set 5 V +1 CR +1 09/19/23, 14:16
-
Oli Bartsch commented on patch set 5 09/19/23, 14:27
LocalDriver.php:51Since this is not set in the constructor, shouldn't this be nullable as well or get some default value? -
Oli Bartsch commented on patch set 5 V -1 09/19/23, 14:29
LocalDriver.php:51ReplyTested the patch. Actually this leads to (1/1) Error Typed property TYPO3\CMS\Core\Resource\Driver\LocalDriver::$absoluteBasePath must not be accessed before initialization when accessing the filelist -
Benni Mack commented on patch set 5 09/19/23, 14:50
Can you show steps to reproduce? Cannot reproduce your problem -
Oli Bartsch commented on patch set 5 09/19/23, 16:44
Reply
Thrown in /var/www/html/typo3/sysext/core/Classes/Resource/Driver/LocalDriver.php line 688. Full stack trace provided via slack. It seems that it's caused by an offline storage (storage on a folder in the file system which does no longer exist). -
Benni Mack uploaded patch set 6
CR +1V +109/19/23, 17:18 -
Oliver Klee voted on patch set 6 CR +1 09/19/23, 17:24
-
core-ci voted on patch set 6 V +1 09/19/23, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46807
-
Oliver Klee voted on patch set 6 V +1 09/19/23, 17:34
-
Oli Bartsch voted on patch set 6 CR +1 09/19/23, 21:13
-
Oli Bartsch uploaded patch set 7
CR +1V +109/19/23, 21:15 -
Oli Bartsch voted on patch set 7 CR +1 09/19/23, 21:15
-
Oliver Klee voted on patch set 7 V +1 CR +1 09/19/23, 21:20
-
core-ci voted on patch set 7 V +1 09/19/23, 21:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46829
-
Andreas Kienast voted on patch set 7 CR +1 09/20/23, 08:54
-
Stefan Bürk voted on patch set 7 V +2 CR +2 09/20/23, 10:04
-
Stefan Bürk merged patch set 8 09/20/23, 10:04
LocalDriver.php:64