Review main Merged

81046[BUGFIX] Only update metadata database row on changes

Oli Bartsch CR +2 V +2 Normal +53 −24 updated 09/18/23, 21:12

Commit message

The @internal update() method of MetaDataRepository
now checks the data to be updated against the current
database row, preventing updating of the records
timestamp in case no actual update needs to be done.

Additionally, the method now returns the database row.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Nedbal +1
    • Stefan Bürk +1
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Nedbal +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1215

  1. Oli Bartsch uploaded patch set 1 09/18/23, 14:09

  2. core-ci voted on patch set 1 V -1 09/18/23, 14:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46673

  3. Oli Bartsch uploaded patch set 2 V -1 09/18/23, 15:10

  4. core-ci voted on patch set 2 V +1 09/18/23, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46681

  5. Oliver Hader commented on patch set 2 09/18/23, 15:30

    MetaDataRepository.php:166

    Even it is `@internal`, I think there should be a backward compatible fallback when the new param is not given.

    MetaDataRepository.php:172

    Would `array_diff($updateRow, $metaDataFromDatabase)` be an option here?
  6. Oli Bartsch uploaded patch set 3 V +1 09/18/23, 17:14

  7. Oli Bartsch commented on patch set 3 09/18/23, 17:17

    MetaDataRepository.php:166 Reply

    Done

    MetaDataRepository.php:172 Reply

    Done
  8. Oliver Hader voted on patch set 3 CR +1 09/18/23, 17:19

  9. core-ci voted on patch set 3 V +1 09/18/23, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46694

  10. Benni Mack voted on patch set 3 V +1 CR +1 09/18/23, 20:13

  11. Stefan Bürk voted on patch set 3 CR +1 09/18/23, 20:35

  12. Stefan Bürk voted on patch set 3 V +1 09/18/23, 20:36

  13. Andreas Nedbal voted on patch set 3 V +1 CR +1 09/18/23, 20:38

  14. Oli Bartsch voted on patch set 3 V +2 CR +2 09/18/23, 21:12

  15. Oli Bartsch merged patch set 4 09/18/23, 21:12