Review main Merged

81050[TASK] Move GraphicalFunctions code to ImageProcessingInstructions

Benni Mack CR +2 V +2 Expert +611 −534 updated 10/11/23, 11:32

Commit message

This change moves some logic to calculate width
and height based on instructions from an incoming
array into a separate DTO, which can be used consistently
and type-safe instead of residing in GraphicalFunctions.

Some transformation of options ("maxW" vs. "maxWidth")
is now moved to this new class as well, in order to
centralize the naming of the options.

In addition, the special calculation for ImageMagick
about the cropH and cropV values is now done directly
in the instructions, so the CropArea object can now
be used in more places than before.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 7