Review main Merged

81051[BUGFIX] Use CKEditor5 GHS attribute for CSS classes in link plugin

Benjamin Franzke CR +2 V +2 Normal +56 −26 updated 09/25/23, 08:35

Commit message

The GHS (General HTML Support [1]) attribute `htmlA` is used by the
style plugin to apply or remove style classes. Make sure to use the
same attribute interface in order for CSS class usage to be interopable
across our set of CKEditor5 plugins.

Note that our custom `linkClass` attribute prevented the CKEditor5
style plugin from parsing existing classes, as this plugin expects
CSS classes to be available on the `htmlA` attribute (defined in
the nested `classes` array).

[1] https://ckeditor.com/docs/ckeditor5/latest/features/html/general-html-support.html

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 4