Review 11.5 Merged

81059[BUGFIX] Do not try to parse non-strings as XML in DataHandler

Stefan Bürk CR +2 V +2 Easy +6 −6 updated 09/18/23, 16:26

Commit message

If the flexforms data is null, there is no point trying to parse
that as XML. This avoids type errors when `GeneralUtility` gets
native parameter type declarations for `GU::xml2array`, and it
should also slightly increase performance.

Also fix the corresponding PHPDoc type annotation to reflect
that a parameter in reality needs to be nullable.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 09/18/23, 15:11

    Cherry Picked from branch 12.4.
  2. core-ci voted on patch set 1 V +1 09/18/23, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46682

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 09/18/23, 16:25

  4. Stefan Bürk merged patch set 2 09/18/23, 16:26