Review 12.4 Merged

81069[TASK] Update to CKEditor5 v39

Benjamin Franzke CR +2 V +2 Nightmare +2564 −1104 updated 09/20/23, 14:14

Commit message

https://ckeditor.com/docs/ckeditor5/latest/updating/guides/update-to-39.html

Executed commands:
  npm install -P $(
    grep ckeditor5 package.json | \
    grep '\^38' | \
    grep -v dev-utils | \
    sed 's/^[^"]*"\([^"]*\)".*/\1@^39/' \
  )
  npm run build

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 65

Show 45 more files

Review log 35

  1. Benjamin Franzke commented on patch set 1 09/20/23, 13:54

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/package-lock.json * Build/package.json
  2. Benjamin Franzke uploaded patch set 2 09/20/23, 13:59

  3. core-ci voted on patch set 1 V -1 09/20/23, 14:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46891

  4. core-ci voted on patch set 2 V +1 09/20/23, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46892

  5. Benjamin Franzke merged patch set 3 09/20/23, 14:14