Review main Merged Breaking

81073[!!!][TASK] Remove various legacy settings from GraphicalFunctions

Benni Mack CR +2 V +2 Hard +92 −181 updated 09/18/23, 20:56

Commit message

TYPO3's powerful image manipulation has some legacy functionality
which is outdated nowadays.

They aren't considered best practices anymore,
and are removed:

* $TYPO3_CONF_VARS[GFX][thumbnails_png]
* $TYPO3_CONF_VARS[GFX][gif_compress]
* TypoScript GIFBUILDER.reduceColors

Reducing colors in GIFs or using GIFs instead of PNGs
were used back then in the 2000's era of the web
to save bandwidth in favor of quality, whereas new
websites use optimized images already. Having
these options serve only little use and can be removed,
as compression can be done on the webserver-level already.

The relevant PHP code is also removed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Nedbal +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Nedbal +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 1116

  1. Benni Mack uploaded patch set 1 09/18/23, 17:51

  2. core-ci voted on patch set 1 V -1 09/18/23, 18:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46697

  3. Benni Mack uploaded patch set 2 V -1 09/18/23, 18:16

  4. Benni Mack uploaded patch set 3 09/18/23, 18:17

  5. core-ci voted on patch set 3 V -1 09/18/23, 18:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46701

  6. core-ci voted on patch set 2 V -1 09/18/23, 18:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46700

  7. Oliver Klee commented on patch set 3 09/18/23, 19:03

    The removed code had some PHPStan warnings. So we'll need to re-generate the PHPStan baseline.
  8. Benni Mack uploaded patch set 4 V -1 09/18/23, 20:05

  9. core-ci voted on patch set 4 V +1 09/18/23, 20:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46709

  10. Andreas Nedbal voted on patch set 4 V +1 CR +1 09/18/23, 20:35

  11. Stefan Bürk commented on patch set 5 CR +1 V +1 09/18/23, 20:43

    Published edit on patch set 4.
  12. Stefan Bürk voted on patch set 5 V +1 CR +1 09/18/23, 20:45

  13. Andreas Nedbal voted on patch set 5 V +1 CR +1 09/18/23, 20:45

  14. core-ci voted on patch set 5 V +1 09/18/23, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46714

  15. Benni Mack voted on patch set 5 V +2 CR +2 09/18/23, 20:56

  16. Benni Mack merged patch set 6 09/18/23, 20:56