Review main Merged

81075[TASK] Use proper File objects in FileProcessingService

Benni Mack CR +2 V +2 Normal +68 −106 updated 09/19/23, 16:02

Commit message

FileProcessingService and its surrounding code
within File / FileReference / ResourceStorage and
ProcessedFileRepository was hinted to use "FileInterface"
which is technically wrong, and - if used - throws
a PHP 8 warning because the ProcessedFileRepository
checks for the "uid" which is not present in a FileInterface
(only for FileReferences, File and ProcessedFile objects).

Since it is technically not possible to process a processed
file due to the DB relations, this code is now
using the correct type hints to avoid PHP errors.

In addition, the FileProcessingService is now made DI-aware,
so it can injected all necessary services.

As this is part of a series to clean up types within
FAL in v13, the PHP method signature changes will
be documented in a separate commit.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 7