Review main Merged

81077[TASK] Remove namespace declaration in ContentSecurityPolicies.php

TYPO3com CR +2 V +2 Easy +0 −10 updated 09/19/23, 14:12

Commit message

There is no point in having namespace declarations
in those config files.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 811

  1. TYPO3com uploaded patch set 1 09/19/23, 03:56

  2. core-ci voted on patch set 1 V +1 09/19/23, 04:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46728

  3. Christian Kuhn commented on patch set 1 CR -1 09/19/23, 10:00

    why do those files have a namespace declaration in the first place? they should vanish from all of them?!
  4. Christian Kuhn uploaded patch set 2 CR -1 V +1 09/19/23, 10:46

  5. Christian Kuhn commented on patch set 2 09/19/23, 10:46

    Reply

    Done
  6. Christian Kuhn voted on patch set 2 V +1 CR +1 09/19/23, 10:47

  7. core-ci voted on patch set 2 V +1 09/19/23, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46758

  8. Oliver Klee voted on patch set 2 V +1 CR +1 09/19/23, 10:57

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 09/19/23, 11:16

  10. Christian Kuhn merged patch set 3 09/19/23, 11:16

  11. Oliver Hader commented on patch set 3 09/19/23, 14:12

    Thx! Probably the same for `Configuration/Services.php`