Review main Merged Breaking

81081[!!!][TASK] Decouple FileRepository and ProcessedFileRepository

Benni Mack CR +2 V +2 Hard +256 −616 updated 09/19/23, 13:55

Commit message

When FAL was introduced in TYPO3 v6.0, some concepts
were introduced which aren't so smart, 11 years later.

* Building an AbstractRepository
* Using Extbase RepositoryInterface in FAL repositories

The shared code between the two implementing
classes, FileRepository and AbstractFileRepository
isn't justified to use an AbstractRepository which
dynamically creates objects through inheritance
for its subclass repositories.

Instead, the AbstractRepository is now removed and
both FileRepository and ProcessedFileRepository
are now free, and can also use DI in a way it was meant.

For this reason, the whole AbstractRepository class
within the "TYPO3\CMS\Core\Resource" namespace is removed
along with the dependency to Extbase in this regard.

FileRepository and ProcessedFileRepository now only
contain the methods they require, and all methods and
properties are fully typed.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 14