Review main Merged Breaking

81084[!!!][TASK] Remove setting 'GFX/processor_allowTemporaryMasksAsPng'

Andreas Nedbal CR +2 V +2 Normal +51 −50 updated 09/19/23, 14:50

Commit message

This setting stems from an even older setting called
'im_mask_temp_ext_gif' which was introduced because of
issues with PNG file generation with some earlier
versions of ImageMagick 5.

TYPO3 requires at least ImageMagick 6 or newer in recent
versions, where PNG generation issues couldn't be observed
using this setting. It's obsolete and removed.

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 2031

Show 36 earlier messages
  1. Andreas Nedbal uploaded patch set 1 09/19/23, 11:04

  2. core-ci voted on patch set 1 V -1 09/19/23, 11:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46760

  3. Andreas Nedbal uploaded patch set 2 V -1 09/19/23, 11:16

  4. core-ci voted on patch set 2 V -1 09/19/23, 11:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46763

  5. Andreas Nedbal uploaded patch set 3 V -1 09/19/23, 12:00

  6. core-ci voted on patch set 3 V -1 09/19/23, 12:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46771

  1. Andreas Nedbal uploaded patch set 4 V -1 09/19/23, 12:21

  2. core-ci voted on patch set 4 V -1 09/19/23, 12:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46774

  3. Andreas Nedbal uploaded patch set 5 V -1 09/19/23, 12:34

  4. core-ci voted on patch set 5 V -1 09/19/23, 12:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46775

  5. Andreas Nedbal uploaded patch set 6 V -1 09/19/23, 12:48

  6. Benni Mack voted on patch set 6 V +1 CR +1 09/19/23, 12:51

  7. core-ci voted on patch set 6 V -1 09/19/23, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46778

  8. Andreas Nedbal uploaded patch set 7 CR +1 V +1 09/19/23, 13:02

  9. core-ci voted on patch set 7 V -1 09/19/23, 13:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46779

  10. Andreas Nedbal uploaded patch set 8 V -1 09/19/23, 13:17

  11. core-ci voted on patch set 8 V -1 09/19/23, 13:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46781

  12. Benni Mack uploaded patch set 9 V -1 09/19/23, 13:52

  13. core-ci voted on patch set 9 V +1 09/19/23, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46787

  14. Benni Mack voted on patch set 9 V +1 CR +1 09/19/23, 14:13

  15. Christian Kuhn commented on patch set 9 CR -1 09/19/23, 14:33

    will apply minor formatting details.
  16. Oli Bartsch commented on patch set 9 09/19/23, 14:34

    SilentConfigurationUpgradeServiceTest.php:395

    Should this line be removed as well?
  17. Christian Kuhn uploaded patch set 10 CR +1 V +1 09/19/23, 14:39

  18. Christian Kuhn commented on patch set 10 09/19/23, 14:41

    SilentConfigurationUpgradeServiceTest.php:395 Reply

    Done
  19. Christian Kuhn uploaded patch set 11 09/19/23, 14:41

  20. Christian Kuhn voted on patch set 11 V +1 CR +1 09/19/23, 14:42

  21. core-ci voted on patch set 10 V +1 09/19/23, 14:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46795

  22. core-ci voted on patch set 11 V +1 09/19/23, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46796

  23. Benni Mack voted on patch set 11 V +1 CR +1 09/19/23, 14:49

  24. Andreas Nedbal voted on patch set 11 V +2 CR +2 09/19/23, 14:50

  25. Andreas Nedbal merged patch set 12 09/19/23, 14:50