81087[TASK] Migrate FAL FileCollector to use Dependency Injection
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1115
-
Benni Mack uploaded patch set 1 09/19/23, 14:15
-
core-ci voted on patch set 1 V -1 09/19/23, 15:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46792
-
Benni Mack uploaded patch set 2
V -109/19/23, 16:01 -
core-ci voted on patch set 2 V -1 09/19/23, 16:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46800
-
Oliver Klee commented on patch set 2 09/19/23, 16:14
FileCollector.php:188`@param 'ascending'|'descending'|'random' $sortingOrder` -
Stefan Bürk uploaded patch set 3
V -109/20/23, 15:14 -
Stefan Bürk uploaded patch set 4 09/20/23, 15:16
-
Oliver Klee commented on patch set 3 09/20/23, 15:16
FileCollector.php:49ReplyDoneFileCollector.php:188ReplyDone -
Stefan Bürk commented on patch set 2 09/20/23, 15:16
FileCollector.php:49ReplyDoneFileCollector.php:188ReplyDone -
core-ci voted on patch set 4 V +1 09/20/23, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46909
-
Oliver Klee voted on patch set 4 V +1 CR +1 09/20/23, 15:27
-
core-ci voted on patch set 3 V +1 09/20/23, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46908
-
Stefan Bürk voted on patch set 4 V +1 CR +1 09/20/23, 15:35
-
Benni Mack voted on patch set 4 V +2 CR +2 09/20/23, 15:36
-
Benni Mack merged patch set 5 09/20/23, 15:36
FileCollector.php:49