Review main Merged

81087[TASK] Migrate FAL FileCollector to use Dependency Injection

Benni Mack CR +2 V +2 Normal +78 −125 updated 09/20/23, 15:36

Commit message

In addition, this class is now fully typed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1115

  1. Benni Mack uploaded patch set 1 09/19/23, 14:15

  2. core-ci voted on patch set 1 V -1 09/19/23, 15:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46792

  3. Benni Mack uploaded patch set 2 V -1 09/19/23, 16:01

  4. core-ci voted on patch set 2 V -1 09/19/23, 16:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46800

  5. Oliver Klee commented on patch set 2 09/19/23, 16:14

    FileCollector.php:49

    `@var FileInterface[]`

    FileCollector.php:188

    `@param 'ascending'|'descending'|'random' $sortingOrder`
  6. Stefan Bürk uploaded patch set 3 V -1 09/20/23, 15:14

  7. Stefan Bürk uploaded patch set 4 09/20/23, 15:16

  8. Oliver Klee commented on patch set 3 09/20/23, 15:16

    FileCollector.php:49 Reply

    Done

    FileCollector.php:188 Reply

    Done
  9. Stefan Bürk commented on patch set 2 09/20/23, 15:16

    FileCollector.php:49 Reply

    Done

    FileCollector.php:188 Reply

    Done
  10. core-ci voted on patch set 4 V +1 09/20/23, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46909

  11. Oliver Klee voted on patch set 4 V +1 CR +1 09/20/23, 15:27

  12. core-ci voted on patch set 3 V +1 09/20/23, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46908

  13. Stefan Bürk voted on patch set 4 V +1 CR +1 09/20/23, 15:35

  14. Benni Mack voted on patch set 4 V +2 CR +2 09/20/23, 15:36

  15. Benni Mack merged patch set 5 09/20/23, 15:36