Review main Abandoned

81090[BUGFIX] Refactored the display of the file references in FormEngine

Sebastian Tittel CR 0 V 0 Easy +8 −2 updated 04/11/25, 21:14

Commit message

A minimum width has been assigned to the thumbnails
and label field of the file references, to make them
more consistent.

In the FileReferenceContainer, the class col-1 is removed
from the "dt" because the width is now specified by the
min-width property.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 711

  1. Sebastian Tittel uploaded patch set 1 09/19/23, 17:28

  2. Sebastian Tittel uploaded patch set 2 09/19/23, 17:36

  3. core-ci voted on patch set 1 V -1 09/19/23, 17:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46808

  4. Sebastian Tittel updated the commit message in patch set 3 09/19/23, 17:42

  5. core-ci voted on patch set 2 V +1 09/19/23, 17:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46810

  6. core-ci voted on patch set 3 V +1 09/19/23, 17:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46811

  7. Oli Bartsch updated the commit message in patch set 4 V +1 09/19/23, 17:56

  8. Oli Bartsch commented on patch set 4 V -1 09/19/23, 18:00

    As discussed, current state does not bring an improvement.
  9. Oli Bartsch commented on patch set 4 09/19/23, 18:00

    Reply Unresolved

    .
  10. core-ci voted on patch set 4 V +1 09/19/23, 18:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46816

  11. Benni Mack abandoned the change 04/11/25, 21:14

    ticket closed, no activity. abandoning this change now