81091[TASK] Move DB related code of EXT:indexed_search to the repository
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Stefan Bürk +1
- Jörg Bösche +1
-
Verified V +2 Done
- Georg Ringer +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1723
-
Georg Ringer uploaded patch set 1 09/19/23, 21:32
-
Georg Ringer commented on patch set 1 09/19/23, 21:32
This change is ready for review. -
core-ci voted on patch set 1 V -1 09/19/23, 21:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46833
-
Georg Ringer uploaded patch set 2
V -109/19/23, 21:54 -
core-ci voted on patch set 2 V +1 09/19/23, 22:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46834
-
Benni Mack voted on patch set 2 CR +1 09/20/23, 09:25
-
Christian Kuhn updated the commit message in patch set 3
CR +1V +109/20/23, 10:11 -
Christian Kuhn voted on patch set 3 V +1 CR +1 09/20/23, 10:11
-
core-ci voted on patch set 3 V +1 09/20/23, 10:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46870
-
Andreas Kienast commented on patch set 3 09/20/23, 11:51
IndexSearchRepository.php:292Can you please add the return type?IndexSearchRepository.php:308Can you please add the return type? -
Georg Ringer uploaded patch set 4
CR +1V +109/20/23, 12:23 -
core-ci voted on patch set 4 V +1 09/20/23, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46881
-
Stefan Bürk commented on patch set 4 CR -1 09/20/23, 19:34
SearchController.php:298Return type should be adjusted and here a check for false or null is needed, depending on return type in the method. See comment for the method in the SearchRepository. It was wrong not to deal with "false" before hand.SearchController.php:722Return type should be adjusted and here a check for false or null is needed, depending on return type in the method. See comment for the method in the SearchRepository. It was wrong not to deal with "false" before hand.IndexSearchRepository.php:292Replysee other comment, should be array|null or array|falseIndexSearchRepository.php:295The array cast feels to be wrong. The return type should be `array|null` or `?array` and than using ``` ->fetchAssociative() ?: null ``` or simply adopt the `array|false` return type.IndexSearchRepository.php:305If only one record is retrieved, a limit(1) should be used. That ensures that at all costs the buffer is cleared. Otherwise it may or may not lead to issues. Therefore, it's good to free the buffer by either retrieving all results, free it forcefully or ensure by using a limit that no unread data is in the buffer. Granted, the simply moved - but let's make that clean here now.IndexSearchRepository.php:308Replysee other comment, should be array|null or array|falseIndexSearchRepository.php:308Same here: The array cast feels to be wrong. The return type should be `array|null` or `?array` and than using ``` ->fetchAssociative() ?: null ``` or simply adopt the `array|false` return type.IndexSearchRepository.php:322If only one record is retrieved, a limit(1) should be used. That ensures that at all costs the buffer is cleared. Otherwise it may or may not lead to issues. Therefore, it's good to free the buffer by either retrieving all results, free it forcefully or ensure by using a limit that no unread data is in the buffer. Granted, the simply moved - but let's make that clean here now. -
Georg Ringer uploaded patch set 5
CR -1V +109/21/23, 05:49 -
core-ci voted on patch set 5 V +1 09/21/23, 05:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46964
-
Oliver Klee commented on patch set 5 09/21/23, 07:32
SearchController.php:298ReplyDoneSearchController.php:299Let's be explicit here (as the variable is not always a boolean): ```php if (is_array($indexCfgRec)) { ``` -
Stefan Bürk uploaded patch set 6
V +109/22/23, 16:24 -
Stefan Bürk commented on patch set 6 V +1 CR +1 09/22/23, 16:24
SearchController.php:299ReplyDoneSearchController.php:722ReplyDoneIndexSearchRepository.php:292ReplyDoneIndexSearchRepository.php:295ReplyDoneIndexSearchRepository.php:305ReplyDoneIndexSearchRepository.php:308ReplyDoneIndexSearchRepository.php:308ReplyDoneIndexSearchRepository.php:322ReplyDone -
core-ci voted on patch set 6 V +1 09/22/23, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47095
-
Oliver Klee voted on patch set 6 CR +1 09/22/23, 17:18
-
Jörg Bösche voted on patch set 6 CR +1 09/28/23, 11:07
-
Georg Ringer voted on patch set 6 V +2 CR +2 09/28/23, 12:29
-
Georg Ringer merged patch set 7 09/28/23, 12:29