Review main Merged

81098[TASK] Use native objects in `@typo3/core/ajax/ajax-request`

Andreas Kienast CR +2 V +2 Normal +27 −40 updated 09/20/23, 13:58

Commit message

The module `@typo3/core/ajax/ajax-request` previously had a lot of
string-based mambo jambo when composing URLs and query strings.

The API is now streamlined to use `URL` and its included `searchParams`
property to build URLs, removing the need to compose URLs manually.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 68

  1. Andreas Kienast uploaded patch set 1 09/20/23, 10:16

  2. core-ci voted on patch set 1 V +1 09/20/23, 10:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46871

  3. Andreas Kienast uploaded patch set 2 V +1 09/20/23, 10:34

  4. core-ci voted on patch set 2 V +1 09/20/23, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46873

  5. Andreas Nedbal voted on patch set 2 V +1 CR +1 09/20/23, 12:47

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 09/20/23, 13:39

  7. Andreas Kienast voted on patch set 2 V +2 CR +2 09/20/23, 13:57

  8. Andreas Kienast merged patch set 3 09/20/23, 13:58