81101[!!!][WIP][TASK] Move image dimension calculation out of GraphicalFunctions
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 4
Review log 57
-
Benni Mack uploaded patch set 1 09/20/23, 11:59
-
Oliver Klee commented on patch set 1 09/20/23, 12:10
ImageDimensionResolver.php:44Unresolved`@return array{0: int, 1: int, 2: string, 3: string}|null` (plus the prose)ImageDimensionResolver.php:76Can we provide more information about this parameter as an array shape?ImageDimensionResolver.php:99Unresolved`@param non-empty-string $filePath`ImageDimensionResolver.php:101Unresolved`@return array{0: int, 1: int, 2: string, 3: string}|false`ImageDimensionResolver.php:136Unresolved`@param non-empty-string $filePath` `@return non-empty-string`ImageDimensionResolver.php:147Unresolved`@param non-empty-string $filePath` `@return non-empty-string` -
core-ci voted on patch set 1 V -1 09/20/23, 12:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46878
-
Benni Mack uploaded patch set 2
V -109/20/23, 12:39 -
Oliver Klee commented on patch set 2 09/20/23, 12:51
ImageDimensionResolver.php:76ReplyDone -
core-ci voted on patch set 2 V -1 09/20/23, 12:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46883
-
Benni Mack abandoned the change 09/20/23, 13:14
wrong approach
ImageDimensionResolver.php:43Unresolved