Review main Merged

81104[TASK] Remove image map code from GifBuilder

Andreas Nedbal CR +2 V +2 Normal +0 −51 updated 09/20/23, 15:20

Commit message

While public, the addToMap method only filled a
protected property without an accessor, so while
a image map exists, it is never used in GifBuilder
or outside of it, warranting the removal of useless
functionality.

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Oliver Klee +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Andreas Nedbal uploaded patch set 1 09/20/23, 12:37

  2. core-ci voted on patch set 1 V +1 09/20/23, 12:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46882

  3. Oliver Klee voted on patch set 1 V +1 CR +1 09/20/23, 12:57

  4. Benni Mack voted on patch set 1 V +1 CR +1 09/20/23, 13:13

  5. Andreas Nedbal voted on patch set 1 V +2 CR +2 09/20/23, 13:14

  6. Andreas Nedbal merged patch set 2 09/20/23, 13:15

  7. Stephan Großberndt commented on patch set 2 09/20/23, 15:20