Review main Merged Breaking

81105[!!!][TASK] Remove cache_imagesizes

Benni Mack CR +2 V +2 Hard +124 −166 updated 09/22/23, 10:33

Commit message

This change removes the cache "imagesizes" along
with the public methods within GraphicalFunctions.

The main reason for having cache_imagesizes back in
TYPO3 v4.x was that detecting the image sizes was done
via ImageMagick solely.

Nowadays, the ImageInfo functionality is used,
which uses

- getimagesize()
- exif_read_data()

before falling back to ImageMagick identify.

Most places in TYPO3 Core already use ImageInfo directly
without using the cache.

A image size calculation is nowadays with SSD much faster
than a decade before, whereas a DB cache (by default) for
cache_imagesizes has a much more latency.

As cache_imagesizes is solely used for local files,
remote FAL drivers do not have a problem here as well.

Removed public methods:
- GraphicalFunctions->cacheImageDimensions()
- GraphicalFunctions->getCachedImageDimensions()

The main public method GraphicalFunctions->getImageDimensions()
still continues to exist and work as before.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 1116

  1. Benni Mack uploaded patch set 1 09/20/23, 13:00

  2. Benni Mack uploaded patch set 2 09/20/23, 13:01

  3. core-ci voted on patch set 1 V +1 09/20/23, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46885

  4. core-ci voted on patch set 2 V +1 09/20/23, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46886

  5. Christian Kuhn voted on patch set 2 CR +1 09/22/23, 08:43

  6. Christian Kuhn commented on patch set 2 09/22/23, 08:44

    let's finish this one.
  7. Benni Mack rebased onto patch set 3 CR +1 V +1 09/22/23, 09:27

  8. core-ci voted on patch set 3 V +1 09/22/23, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47069

  9. Benni Mack uploaded patch set 4 V +1 09/22/23, 10:01

  10. Christian Kuhn commented on patch set 5 09/22/23, 10:04

    Published edit on patch set 4.
  11. Christian Kuhn voted on patch set 5 V +1 CR +1 09/22/23, 10:04

  12. core-ci voted on patch set 4 V +1 09/22/23, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47073

  13. core-ci voted on patch set 5 V +1 09/22/23, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47074

  14. Stefan Bürk voted on patch set 5 V +1 CR +1 09/22/23, 10:31

  15. Benni Mack voted on patch set 5 V +2 CR +2 09/22/23, 10:33

  16. Benni Mack merged patch set 6 09/22/23, 10:33