Review main Merged

81113[BUGFIX] Inform about online media already exists

Oli Bartsch CR +2 V +2 Normal +89 −24 updated 09/20/23, 19:27

Commit message

In case a user adds an online media asset,
which is already present in the target folder
a flash message now properly informs about
it instead of stating that the asset was
"added successfully".

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1013

  1. Oli Bartsch uploaded patch set 1 09/20/23, 15:53

  2. core-ci voted on patch set 1 V -1 09/20/23, 16:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46914

  3. Oli Bartsch uploaded patch set 2 V -1 09/20/23, 18:54

  4. Stefan Bürk commented on patch set 2 09/20/23, 19:04

    OnlineMediaAlreadyExistsException.php:32

    I guess we should add at pass a static message to the parent constructor here to have a sentence if the Exception may occure on some log or xdebug. Not blocking, but I guess this would not hurt. What do you think ?
  5. core-ci voted on patch set 2 V -1 09/20/23, 19:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46916

  6. Oli Bartsch uploaded patch set 3 V -1 09/20/23, 19:08

  7. Oli Bartsch commented on patch set 3 09/20/23, 19:09

    OnlineMediaAlreadyExistsException.php:32 Reply

    Absolutely, added corresponding message.
  8. Stefan Bürk commented on patch set 3 09/20/23, 19:09

    OnlineMediaAlreadyExistsException.php:32 Reply

    Done
  9. Stefan Bürk voted on patch set 3 V +1 CR +1 09/20/23, 19:13

  10. core-ci voted on patch set 3 V +1 09/20/23, 19:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46917

  11. Benni Mack voted on patch set 3 V +1 CR +1 09/20/23, 19:26

  12. Oli Bartsch voted on patch set 3 V +2 CR +2 09/20/23, 19:27

  13. Oli Bartsch merged patch set 4 09/20/23, 19:27