Review main Merged

81115[BUGFIX] Use "sample" instead of "useSample" in FAL processing

Benni Mack CR +2 V +2 Easy +10 −5 updated 09/20/23, 21:43

Commit message

When using TypoScript, the setting "sample" allows
to scale faster than with "geometry" setting.

However, when FAL was introduced the setting was called
"useSample" which never worked since TYPO3 v6.0 in
conjunction with FAL.

The option is however useful and is now working again.

The according code is moved into GraphicalFunctions
in order to avoid future access to this public property.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 710

  1. Benni Mack uploaded patch set 1 09/20/23, 19:17

  2. core-ci voted on patch set 1 V +1 09/20/23, 19:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46919

  3. Stefan Bürk uploaded patch set 2 V +1 09/20/23, 20:58

  4. core-ci voted on patch set 2 V -1 09/20/23, 21:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46931

  5. Stefan Bürk uploaded patch set 3 V -1 09/20/23, 21:19

  6. core-ci voted on patch set 3 V +1 09/20/23, 21:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46934

  7. Stefan Bürk voted on patch set 3 V +1 CR +1 09/20/23, 21:27

  8. Oli Bartsch voted on patch set 3 V +1 CR +1 09/20/23, 21:41

  9. Benni Mack voted on patch set 3 V +2 CR +2 09/20/23, 21:43

  10. Benni Mack merged patch set 4 09/20/23, 21:43