Review main Merged

81118[BUGFIX] Add more inputs for GifBuilder hash uniqueness

Andreas Nedbal CR +2 V +2 Easy +2 −0 updated 09/20/23, 21:01

Commit message

The previous hashing inputs didn't include the X/Y coordinates
or the calculated offsets, so similarly configured GIFBUILDERs
had a high likelyhood of loading older images.

Adding more inputs, but not falling back to fully encoding all
of $this->setup should keep the performance and increase
uniqueness.

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Andreas Nedbal uploaded patch set 1 09/20/23, 20:45

  2. core-ci voted on patch set 1 V +1 09/20/23, 20:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46930

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 09/20/23, 20:52

  4. Oliver Klee voted on patch set 1 CR +1 09/20/23, 20:58

  5. Stefan Bürk voted on patch set 1 V +1 CR +1 09/20/23, 21:00

  6. Andreas Nedbal voted on patch set 1 V +2 CR +2 09/20/23, 21:01

  7. Andreas Nedbal merged patch set 2 09/20/23, 21:01