Review main Merged

81119[TASK] Remove superflous fallback guard in ContentObjectRenderer

Stefan Bürk CR +2 V +2 Easy +11 −17 updated 09/20/23, 22:10

Commit message

In `ContentObjectRenderer->getImgResource()` null coalescing operator
has been used to guard type errors. That has been guarded by a early
array check and ensurance, therefore the guards are obselete. Remove
them !

Used command(s):

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1012

  1. Stefan Bürk uploaded patch set 1 09/20/23, 21:25

  2. Stefan Bürk updated the commit message in patch set 2 09/20/23, 21:26

  3. Benni Mack voted on patch set 2 V +1 CR +1 09/20/23, 21:30

  4. Stefan Bürk uploaded patch set 3 CR +1 V +1 09/20/23, 21:30

  5. core-ci voted on patch set 3 V +1 09/20/23, 21:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46937

  6. Oli Bartsch voted on patch set 3 V +1 CR +1 09/20/23, 21:41

  7. Stefan Bürk uploaded patch set 4 CR +1 V +1 09/20/23, 21:50

  8. Oli Bartsch voted on patch set 4 V +1 CR +1 09/20/23, 22:03

  9. Benni Mack voted on patch set 4 V +1 CR +1 09/20/23, 22:09

  10. core-ci voted on patch set 4 V +1 09/20/23, 22:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46944

  11. Stefan Bürk voted on patch set 4 V +2 CR +2 09/20/23, 22:10

  12. Stefan Bürk merged patch set 5 09/20/23, 22:10