Review main Merged

81121[BUGFIX] Use proper sample option in GraphicalFunctions

Benni Mack CR +2 V +2 Easy +7 −3 updated 09/20/23, 22:18

Commit message

This change fixes a minor regression introduced
in GraphicalFunctions when $this->scalecmd
was used within GifBuilder to show proper images.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 57

  1. Benni Mack uploaded patch set 1 09/20/23, 22:00

  2. Benni Mack updated the commit message in patch set 2 09/20/23, 22:03

  3. core-ci voted on patch set 1 V +1 09/20/23, 22:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46946

  4. core-ci voted on patch set 2 V +1 09/20/23, 22:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46947

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 09/20/23, 22:17

  6. Oli Bartsch voted on patch set 2 V +2 CR +2 09/20/23, 22:17

  7. Oli Bartsch merged patch set 3 09/20/23, 22:18