Review main Merged

81122[BUGFIX] Use serialized variant of setup in GifBuilder hash

Andreas Nedbal CR +2 V +2 Easy +6 −3 updated 09/21/23, 10:03

Commit message

If generated images used the exact X/Y coordinates all time (as in one documentation example) the initial image would always be reused.

Serializing the setup array using ConfigurationService::serialize keeps performance but includes enough data to never reuse similarly positioned mask images.

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1518

  1. Andreas Nedbal uploaded patch set 1 09/20/23, 22:16

  2. Andreas Nedbal uploaded patch set 2 09/20/23, 22:20

  3. Andreas Nedbal updated the commit message in patch set 3 09/20/23, 22:24

  4. Andreas Nedbal updated the commit message in patch set 4 09/20/23, 22:24

  5. Simon Schaufelberger updated the commit message in patch set 5 09/20/23, 22:27

  6. core-ci voted on patch set 5 V +1 09/20/23, 22:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46955

  7. Stefan Bürk voted on patch set 5 V +1 CR +1 09/20/23, 22:39

  8. core-ci voted on patch set 4 V +1 09/20/23, 22:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46954

  9. Benni Mack voted on patch set 5 V +1 CR +1 09/20/23, 23:08

  10. Garvin Hicking voted on patch set 5 V +1 CR +1 09/21/23, 05:17

  11. Andreas Nedbal updated the commit message in patch set 6 CR +1 V +1 09/21/23, 06:55

  12. Andreas Nedbal commented on patch set 6 09/21/23, 06:59

    We had a discussion internally and decided to not include 11.5 in backports for this patch, because as every gifbuilder hash is invalidated through it, it might cause problems for instances "casually" updating to it.
  13. core-ci voted on patch set 6 V +1 09/21/23, 07:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46968

  14. Benni Mack voted on patch set 6 V +1 CR +1 09/21/23, 07:03

  15. Stefan Bürk voted on patch set 6 V +1 CR +1 09/21/23, 07:08

  16. Andreas Nedbal voted on patch set 6 V +2 CR +2 09/21/23, 07:09

  17. Andreas Nedbal merged patch set 7 09/21/23, 07:09

  18. Simon Schaufelberger commented on patch set 7 09/21/23, 10:03

    Reply

    I can't think of any problems that might come up but chances are very low that people actually stumble over this bug anyway. I just noticed it because i tried out the documentation typoscript.