Review main Merged

81124[DOCS] Add PHP warning impact for usergroup_cached_list field

Daniel Siepmann CR +2 V +2 Easy +7 −1 updated 09/21/23, 08:39

Commit message

The change log previously only mentioned the database impact.
But code might access the field as array key on the user array.
This would result in unexpected behaviour.
Furthermore this would result in Warnings since PHP 8.0.

The changelog is extended with the impact.
That allows people to not only check database queries but also array
access while migrating.

Furthermore suggested migration class was replaced by the FQCN to ease
migration. People do no longer need to find the FQCN. Furthermore it
might exist a class with same name in the project from third party code,
or it might be added another class in the future.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Daniel Siepmann uploaded patch set 1 09/21/23, 06:00

  2. core-ci voted on patch set 1 V +1 09/21/23, 06:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46965

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 09/21/23, 07:10

  4. Oliver Klee voted on patch set 1 V +1 CR +1 09/21/23, 07:30

  5. Oli Bartsch updated the commit message in patch set 2 CR +1 V +1 09/21/23, 08:08

  6. Oli Bartsch voted on patch set 2 V +1 CR +1 09/21/23, 08:08

  7. Stefan Bürk voted on patch set 2 V +2 CR +2 09/21/23, 08:12

  8. core-ci voted on patch set 2 V +1 09/21/23, 08:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46977

  9. Stefan Bürk merged patch set 3 09/21/23, 08:39