81131[TASK] Add missing PHP types to DatabaseRecordList
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 4
Review log 2734
Show 69 earlier messages
-
Benjamin Kott uploaded patch set 1 09/21/23, 08:41
-
core-ci voted on patch set 1 V -1 09/21/23, 08:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46984
-
Benjamin Kott uploaded patch set 2
V -109/21/23, 09:12 -
core-ci voted on patch set 2 V -1 09/21/23, 09:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46990
-
Oliver Klee commented on patch set 2 09/21/23, 09:25
DatabaseRecordList.php:162Was can drop the PHPDoc annotation as it's redundant with the native declaration now.DatabaseRecordList.php:1358`: string`DatabaseRecordList.php:2618I personally would find it cleaner to make `$this->id` nullable and then use `is_int` here (as then it's obvious to the reader that we want an int here). -
Benjamin Kott uploaded patch set 3
V -109/21/23, 09:41 -
Benjamin Kott commented on patch set 3 09/21/23, 09:43
DatabaseBrowser.php:46ReplyDoneDatabaseRecordList.php:162ReplyDoneDatabaseRecordList.php:1358ReplyDoneDatabaseRecordList.php:2618Replyi am still trying to avoid change of behaviour, and only force types and make errors visible, i am still unsure how it would affect the code if we make this nullable. -
core-ci voted on patch set 3 V +1 09/21/23, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46993
-
Benjamin Kott uploaded patch set 4
V +109/21/23, 10:05
-
Benjamin Kott commented on patch set 4 09/21/23, 10:07
DatabaseRecordList.php:2618ReplyWe need to fine the place where listUrl is used without a started recordlist - check is removed again. -
Oliver Klee commented on patch set 4 V +1 CR +1 09/21/23, 10:08
DatabaseRecordList.php:2618ReplyAck -
Oliver Klee voted on patch set 4 CR 0 09/21/23, 10:08
-
Oliver Klee voted on patch set 4 CR +1 09/21/23, 10:08
-
core-ci voted on patch set 4 V -1 09/21/23, 10:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46997
-
Oliver Klee voted on patch set 4 V 0 09/21/23, 10:23
-
Oliver Klee voted on patch set 4 CR 0 09/21/23, 10:26
-
Benjamin Kott uploaded patch set 5
V -109/21/23, 10:52 -
core-ci voted on patch set 5 V +1 09/21/23, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47005
-
Oliver Klee commented on patch set 5 V +1 09/21/23, 11:04
RecordListController.php:166typo: `lustUrl` -> `listUrl` ```php // otherwise `DatabaseRecordList->listUrl` cannot be accessed. ```DatabaseRecordList.php:185`@var int<0, 10000>`DatabaseRecordList.php:244`@var int<0, 1000>` -
Benjamin Kott uploaded patch set 6
V +109/21/23, 11:16 -
Benjamin Kott commented on patch set 6 09/21/23, 11:24
RecordListController.php:166ReplyDoneDatabaseRecordList.php:185Replyeven we force this in the start procedure, we would like to avoid this for now - we need to check how nessesary this really is, and since it´s public it could be set from the outside anyway after the start method was called.DatabaseRecordList.php:244Replyeven we force this in the start procedure, we would like to avoid this for now - we need to check how nessesary this really is, and since it´s public it could be set from the outside anyway after the start method was called. -
core-ci voted on patch set 6 V +1 09/21/23, 11:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47008
-
Oliver Klee voted on patch set 6 V +1 CR +1 09/21/23, 11:32
-
Benni Mack commented on patch set 6 09/21/23, 12:31
I would suggest not to backport this to v12... -
Benjamin Kott commented on patch set 6 09/21/23, 12:41
Reply Unresolved
if we don´t backport this to v12, we are still struggling resolving bugs in the record list, this is only an extract of https://review.typo3.org/c/Packages/TYPO3.CMS/+/80762 to make the nessesary changes better visible in the review itself. -
Oliver Klee voted on patch set 6 CR 0 09/21/23, 12:45
-
Georg Ringer commented on patch set 6 V +1 CR +1 09/21/23, 19:42
looks good on a v12 for me - however one little change would be nice in v12: don't force the type hint on the method start() as this is the most important method but I can also adopt my code quite easily -
Oliver Klee commented on patch set 6 10/08/23, 13:21
Unresolved
How should we proceed here? -
Oliver Klee voted on patch set 6 V 0 10/08/23, 13:21
-
Oliver Klee commented on patch set 6 10/08/23, 13:22
DatabaseBrowser.php:46UnresolvedNow that this property has a type, it should get a default value of `null` as it is not set in a constructor. -
Oliver Hader updated the commit message in patch set 7
CR +1V +110/18/24, 14:11 -
Oliver Hader rebased onto patch set 8 12/13/24, 14:15
-
core-ci voted on patch set 8 V +1 12/13/24, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71069
-
Benni Mack abandoned the change 12/17/24, 18:49
won't do. no activity since 1+ year. Goal is unclear and issue not obvious. Will drop it.
DatabaseBrowser.php:46