Review main Merged

81156[BUGFIX] Restore file.crop syntax in PHP 8

Benni Mack CR +2 V +2 Easy +1 −0 updated 09/22/23, 17:27

Commit message

When using "file.crop" via TypoScript, PHP 8
requires strict types for float values.
Therefore, all values, which were strings
before, are now properly casted to floats,
avoiding PHP errors.

Example TypoScript:

page.10 = IMAGE
page.10 {
  file = 1:/myimage.jpg
  file.ext = png
  file.width = 200
  file.height = 200
  file.crop = 50,50,100,100
}

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1012

  1. Benni Mack uploaded patch set 1 09/21/23, 13:42

  2. core-ci voted on patch set 1 V +1 09/21/23, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47015

  3. Oliver Klee voted on patch set 1 CR +1 09/21/23, 16:10

  4. Oli Bartsch uploaded patch set 2 CR +1 V +1 09/21/23, 16:56

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 09/21/23, 16:58

  6. core-ci voted on patch set 2 V +1 09/21/23, 17:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47023

  7. Oliver Klee voted on patch set 2 CR +1 09/21/23, 17:13

  8. Oliver Klee commented on patch set 2 09/21/23, 18:57

    Is there any way we could cover this with a test?
  9. Oliver Klee commented on patch set 2 09/22/23, 16:57

    Reply

    Okay, let's skip the tests for this bugfix.
  10. Oliver Klee voted on patch set 2 V +1 09/22/23, 16:57

  11. Stefan Bürk voted on patch set 2 V +2 CR +2 09/22/23, 17:18

  12. Stefan Bürk merged patch set 3 09/22/23, 17:27