81159[BUGFIX] Prevent writing failed external file content result to disk
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 56
-
Nikita Hovratov uploaded patch set 1 09/21/23, 15:47
-
core-ci voted on patch set 1 V +1 09/21/23, 15:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47019
-
Christian Kuhn commented on patch set 1 09/21/23, 15:59
-
Nikita Hovratov commented on patch set 1 09/21/23, 17:27
ResourceCompressor.php:588Reply Unresolvedyes lolli, this method is bad. But: I wanted to restore the old behavior with PHP 7.4 where types were not enforced in fwrite. Maybe we could first get this in and then improve it in main. Anyway, I got this error with an includeCSS on a non-existing file. Of course it would be better to display an error: "Hey, this file does not exist.". But to not be breaking for older versions, this should be handled gracefully. -
Oliver Klee commented on patch set 1 10/08/23, 13:25
How should we proceed here? -
Nikita Hovratov abandoned the change 02/18/24, 15:58
Not working on this anymore.
ResourceCompressor.php:588