Review main Merged

81162[BUGFIX] Restore task group collapse state handling

Oli Bartsch CR +2 V +2 Easy +8 −5 updated 09/22/23, 08:41

Commit message

The scheduler module stores the information
about each tasks groups collapse state for
each user. When accessing the module, the
correct state is now resolved again.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Oli Bartsch uploaded patch set 1 09/21/23, 17:57

  2. core-ci voted on patch set 1 V +1 09/21/23, 18:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47026

  3. Jochen Roth voted on patch set 1 V +1 CR +1 09/21/23, 18:53

  4. Oliver Klee commented on patch set 1 09/21/23, 18:55

    SchedulerModuleController.php:571

    Please let‘s have parameter and return type declarations for the arrow functions so the reader knows which types are expected/returned.
  5. Oli Bartsch uploaded patch set 2 CR +1 V +1 09/22/23, 07:30

  6. Oli Bartsch commented on patch set 2 09/22/23, 07:31

    SchedulerModuleController.php:571 Reply

    Done
  7. core-ci voted on patch set 2 V +1 09/22/23, 07:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47052

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 09/22/23, 07:39

  9. Jochen Roth voted on patch set 2 V +1 CR +1 09/22/23, 07:41

  10. Stefan Bürk voted on patch set 2 V +2 CR +2 09/22/23, 08:19

  11. Stefan Bürk merged patch set 3 09/22/23, 08:41