81164[TASK] Add request object to Canonical Tag generation link
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+1 −1
- typo3/sysext/seo/Classes/Canonical/CanonicalGenerator.php+4 −2
- typo3/sysext/seo/Classes/Event/ModifyUrlForCanonicalTagEvent.php+19 −2
- typo3/sysext/seo/Tests/Functional/Canonical/CanonicalGeneratorTest.php+37 −0
- typo3/sysext/seo/Tests/Unit/Event/ModifyUrlForCanonicalTagEventTest.phpnew+42 −0
Review log 1421
-
Benni Mack uploaded patch set 1 09/21/23, 19:56
-
Benni Mack updated the commit message in patch set 2 09/21/23, 19:57
-
core-ci voted on patch set 1 V +1 09/21/23, 20:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47031
-
core-ci voted on patch set 2 V +1 09/21/23, 20:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47032
-
Benni Mack updated the commit message in patch set 3
V +109/21/23, 20:28 -
core-ci voted on patch set 3 V +1 09/21/23, 20:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47035
-
Stefan Bürk updated the commit message in patch set 4
V +109/21/23, 20:43 -
core-ci voted on patch set 4 V +1 09/21/23, 20:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47036
-
Stefan Bürk commented on patch set 4 V +1 CR +1 09/22/23, 13:07
Interesting that no test adoptions are needed. Not looked, but would guess that this is not covered by tests at all. -
Benni Mack commented on patch set 4 09/22/23, 13:23
The main reason is that the Generator itself was built from a hook (which is internal), so this whole setup will be changed at some point. (that was already the case in v10 though...) -
Benni Mack uploaded patch set 5
CR +1V +112/04/23, 11:55 -
core-ci voted on patch set 5 V +1 12/04/23, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50319
-
Oli Bartsch uploaded patch set 6
V +112/04/23, 16:21 -
Oli Bartsch commented on patch set 6 CR +1 V +1 12/04/23, 16:21
Reply
There were no tests at all. I added some. -
core-ci voted on patch set 6 V -1 12/04/23, 16:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50329
-
Oli Bartsch uploaded patch set 7
CR +1V +112/04/23, 17:03 -
core-ci voted on patch set 7 V +1 12/04/23, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50333
-
Oli Bartsch voted on patch set 7 CR +1 V +1 12/04/23, 17:17
-
Christian Kuhn voted on patch set 7 CR +1 V +1 12/04/23, 17:43
-
Benni Mack voted on patch set 7 CR +2 V +2 12/04/23, 18:13
-
Benni Mack merged patch set 8 12/04/23, 18:13