Review main Merged

81164[TASK] Add request object to Canonical Tag generation link

Benni Mack CR +2 V +2 Normal +103 −5 updated 12/04/23, 18:13

Commit message

The PSR-14 ModifyUrlForCanonicalTagEvent was one of the first PSR-14
events to be added to TYPO3 Core, and was rather useless, as it
did not contain the context to deal with creating a URl for the
canonical tag.

In order to make it useful, some more information is added to
the Event object.

This is a pre-cursor for a breaking change, for issue #99807.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 1421

  1. Benni Mack uploaded patch set 1 09/21/23, 19:56

  2. Benni Mack updated the commit message in patch set 2 09/21/23, 19:57

  3. core-ci voted on patch set 1 V +1 09/21/23, 20:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47031

  4. core-ci voted on patch set 2 V +1 09/21/23, 20:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47032

  5. Benni Mack updated the commit message in patch set 3 V +1 09/21/23, 20:28

  6. core-ci voted on patch set 3 V +1 09/21/23, 20:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47035

  7. Stefan Bürk updated the commit message in patch set 4 V +1 09/21/23, 20:43

  8. core-ci voted on patch set 4 V +1 09/21/23, 20:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47036

  9. Stefan Bürk commented on patch set 4 V +1 CR +1 09/22/23, 13:07

    Interesting that no test adoptions are needed. Not looked, but would guess that this is not covered by tests at all.
  10. Benni Mack commented on patch set 4 09/22/23, 13:23

    The main reason is that the Generator itself was built from a hook (which is internal), so this whole setup will be changed at some point. (that was already the case in v10 though...)
  11. Benni Mack uploaded patch set 5 CR +1 V +1 12/04/23, 11:55

  12. core-ci voted on patch set 5 V +1 12/04/23, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50319

  13. Oli Bartsch uploaded patch set 6 V +1 12/04/23, 16:21

  14. Oli Bartsch commented on patch set 6 CR +1 V +1 12/04/23, 16:21

    Reply

    There were no tests at all. I added some.
  15. core-ci voted on patch set 6 V -1 12/04/23, 16:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50329

  16. Oli Bartsch uploaded patch set 7 CR +1 V +1 12/04/23, 17:03

  17. core-ci voted on patch set 7 V +1 12/04/23, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50333

  18. Oli Bartsch voted on patch set 7 CR +1 V +1 12/04/23, 17:17

  19. Christian Kuhn voted on patch set 7 CR +1 V +1 12/04/23, 17:43

  20. Benni Mack voted on patch set 7 CR +2 V +2 12/04/23, 18:13

  21. Benni Mack merged patch set 8 12/04/23, 18:13