Review main Merged

81165[BUGFIX] Cast to string before using GU:trimExplode in indexed_search

Georg Ringer CR +2 V +2 Easy +1 −1 updated 09/22/23, 09:22

Commit message

As the keyword field can be null, the value must be cast to a string.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Georg Ringer uploaded patch set 1 09/21/23, 19:57

  2. Georg Ringer commented on patch set 1 09/21/23, 19:57

    This change is ready for review.
  3. Benni Mack commented on patch set 1 09/21/23, 19:58

    This also affects 11.5 due to the PHP8 migration.
  4. Benni Mack updated the commit message in patch set 2 09/21/23, 19:58

  5. core-ci voted on patch set 1 V +1 09/21/23, 20:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47033

  6. core-ci voted on patch set 2 V +1 09/21/23, 20:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47034

  7. Oliver Klee updated the commit message in patch set 3 V +1 09/21/23, 20:43

  8. Oliver Klee voted on patch set 3 V +1 CR +1 09/21/23, 20:43

  9. core-ci voted on patch set 3 V +1 09/21/23, 20:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47037

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 09/22/23, 09:22

  11. Christian Kuhn merged patch set 4 09/22/23, 09:22