Review 12.4 Merged

81183[DOCS] Add missing links in lowlevel's Configuration module docs

Chris Müller CR +2 V +2 Easy +5 −2 updated 09/25/23, 17:50

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 1012

  1. Chris Müller uploaded patch set 1 09/22/23, 18:53

  2. core-ci voted on patch set 1 V +1 09/22/23, 19:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47102

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 09/22/23, 21:15

  4. Benjamin Franzke commented on patch set 1 CR -1 09/25/23, 12:36

    Settings.cfg:61

    All other links use `main`, why `12.4` here? Isn't `main` automatically substituted?
  5. Chris Müller commented on patch set 1 09/25/23, 13:23

    Settings.cfg:61 Reply

    As this is a new reference, I've done it correctly. And the others (and also in other sysext manuals) are adjusted in a follow-up PR (when this is merged to avoid conflicts).
  6. Benjamin Franzke commented on patch set 1 09/25/23, 13:36

    Settings.cfg:61 Reply

    Please elaborate on that topic beforehand. Does that mean we'd need to replace all `main` links whenever we branch a new major release? …anyway I actually think it makes more sense to add this link with the current approach and apply the "new" one (if we agree on that) in a later patch for all cases. Feel free to push the follow-up PR directly (can be commited and pushed on top of this patch, is then called a Gerrit relation chain), and please add a link to a related docs-rendering-change/issue.
  7. Chris Müller uploaded patch set 2 CR +1 V +1 09/25/23, 13:53

  8. Lina Wolf commented on patch set 1 09/25/23, 13:54

    Settings.cfg:61 Reply

    If we would use the main link here that would mean whenever someone is in the v12.4 version of the manual "lowlevel" and they clicks the link that chris just introduced then they would end up in the main version of reactions. Therefore Chris' approach is the correct one and previously introduced linke like the one to ext_form have been incorrectly backlinked or not dealed with on branching off v12
  9. Chris Müller commented on patch set 2 09/25/23, 13:55

    Settings.cfg:61 Reply

    Use main now and will adjust it in another PR. And yes, when branching we have to adjust the references to the manuals in the branch. For example here: https://docs.typo3.org/c/typo3/cms-felogin/12.4/en-us/Events/Index.html "main" is references in the links, not 12.4.
  10. core-ci voted on patch set 2 V +1 09/25/23, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47160

  11. Benjamin Franzke commented on patch set 2 V +2 CR +2 09/25/23, 17:50

    Settings.cfg:61 Reply

    Thanks
  12. Benjamin Franzke merged patch set 3 09/25/23, 17:50