81184[!!!][TASK] Remove legacy setting 'GFX/gdlib_png'
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Andreas Kienast +1
-
Verified V +2 Done
- Stefan Bürk +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 16
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php5+23 −16
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −2
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml2+1 −4
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102020-RemovedLegacySettingGFXgdlib_png.rstnew+60 −0
- typo3/sysext/core/Resources/Public/Images/NotFound.gifdeletedbinary
- typo3/sysext/frontend/Classes/Imaging/GifBuilder.php4+19 −29
- typo3/sysext/install/Classes/Configuration/Image/GraphicsMagickPreset.php+0 −1
- typo3/sysext/install/Classes/Configuration/Image/ImageMagick6Preset.php+0 −1
- typo3/sysext/install/Classes/Controller/EnvironmentController.php2+14 −20
- typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php+25 −0
- typo3/sysext/install/Resources/Public/Images/TestReference/Gdlib-box.gifdeletedbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Gdlib-niceText.gifdeletedbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Gdlib-shadow.gifdeletedbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Gdlib-simple.gifdeletedbinary
- typo3/sysext/install/Resources/Public/Images/TestReference/Gdlib-text.gifdeletedbinary
- typo3/sysext/install/Tests/Functional/Service/SilentConfigurationUpgradeServiceTest.php+43 −0
Review log 3040
Show 1115 earlier messages
-
Andreas Nedbal uploaded patch set 1 09/23/23, 01:11
-
Andreas Nedbal uploaded patch set 2 09/23/23, 01:13
-
core-ci voted on patch set 1 V +1 09/23/23, 01:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47107
-
core-ci voted on patch set 2 V +1 09/23/23, 01:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47108
-
Stephan Großberndt commented on patch set 2 09/23/23, 05:43
Why don't we migrate the colorspace as well if Imagagick is selected? Also the current default combination still is ImageMagick with RGB? -
Oliver Klee commented on patch set 2 09/23/23, 07:10
GraphicalFunctions.php:42We probably need to reword or remove this comment now. And do we still need this property at all now? -
Andreas Nedbal uploaded patch set 3
V +109/23/23, 17:17 -
core-ci voted on patch set 3 V +1 09/23/23, 17:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47115
-
Andreas Nedbal commented on patch set 3 09/23/23, 17:53
GraphicalFunctions.php:42ReplyDone -
Oliver Klee voted on patch set 3 CR +1 09/23/23, 18:06
-
Benni Mack commented on patch set 3 09/24/23, 10:32
OK. I do think we should deal with the `processor_colorspace` setting as well. This is what I propose: * DefaultConfiguration is setting this option to empty (or even null?) as well * A silentConfigurationUpgrade checks if processor is IM6 and colorspace "sRGB" we can remove it from local configuration * When the processor is "GM" and "RGB" we can remove it as well * When using the option, we check if it is empty/null within GraphicalFunctions, and if so, use the right value ("sRGB" and "RGB" depending on the processor). This way, 80% of the users get the right setting with a DefaultConfiguration which only contains the parts that are relevant, but people with a custom colorspace can configure it manually in LocalConfiguration.php / settings.php. WDYT? -
Andreas Nedbal commented on patch set 3 09/24/23, 14:52
Reply
Sounds like a good idea to me! -
Andreas Nedbal uploaded patch set 4
CR +1V +109/24/23, 15:39 -
core-ci voted on patch set 4 V -1 09/24/23, 15:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47123
-
Andreas Nedbal uploaded patch set 5
V -109/24/23, 16:21
-
Benni Mack commented on patch set 5 09/24/23, 16:25
reads very well so far, can you also update the RST on how the setting colorspace works and what we've changed? -
Benni Mack commented on patch set 5 09/24/23, 16:25
GifBuilder.php:1421I think we can skip this one -
core-ci voted on patch set 5 V -1 09/24/23, 16:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47125
-
Andreas Nedbal uploaded patch set 6
V -109/24/23, 16:33 -
Andreas Nedbal uploaded patch set 7 09/24/23, 16:34
-
core-ci voted on patch set 7 V -1 09/24/23, 16:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47128
-
core-ci voted on patch set 6 V -1 09/24/23, 16:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47127
-
Andreas Nedbal uploaded patch set 8
V -109/24/23, 16:45 -
Andreas Nedbal commented on patch set 8 09/24/23, 16:46
Reply
Done -
core-ci voted on patch set 8 V +1 09/24/23, 16:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47129
-
Georg Ringer voted on patch set 8 CR +1 09/25/23, 06:08
-
Andreas Kienast commented on patch set 8 CR -1 09/25/23, 08:12
GraphicalFunctions.php:46The removal of this property is not documented, yet.GifBuilder.php:2725The file `typo3/sysext/core/Resources/Public/Images/NotFound.gif` can be deleted, but that probably requires a mention in the ReST.EnvironmentController.php:749All `typo3/sysext/install/Resources/Public/Images/TestReference/Gdlib-*.gif` files can be removed, right? -
Stephan Großberndt commented on patch set 8 CR -1 09/25/23, 11:59
typo3/sysext/install/Classes/Configuration/Image/GraphicsMagickPreset.php and typo3/sysext/install/Classes/Configuration/Image/ImageMagick6Preset.php set GFX/processor_colorspace as well, they should be adapted then too. Currently they set 'RGB'/'sRGB' explicitly, this should probably be changed to set an empty string instead so the new default handling is triggered? -
Stephan Großberndt commented on patch set 8 09/25/23, 12:16
DefaultConfigurationDescription.yaml:43From https://legacy.imagemagick.org/Usage/resize/ : "As of version 6.7.5 ImageMagick follows this convention and defines the default colorspace of images (at least for most image file formats) to be sRGB." As even Debian has had an ImageMagick version > 6.7.5 in Wheezy in 2012 https://launchpad.net/debian/wheezy/+source/imagemagick I think it is safe to omit the version information and rephrase this to sth like Specify the colorspace to use. Defaults to "RGB" when using GraphicsMagick as processor and "sRGB" when using ImageMagick. Images would be rendered darker than the original when using ImageMagick in combination with "RGB". -
Andreas Nedbal uploaded patch set 9
CR +1V +109/25/23, 13:23 -
core-ci voted on patch set 9 V +1 09/25/23, 13:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47157
-
Andreas Nedbal commented on patch set 9 09/25/23, 13:39
GraphicalFunctions.php:46ReplyDoneDefaultConfigurationDescription.yaml:43ReplyDoneGifBuilder.php:2725ReplyDoneEnvironmentController.php:749ReplyDone -
Stephan Großberndt commented on patch set 9 CR -1 09/25/23, 14:38
Reply
This comment had been marked as resolved, but it isn't resolved yet. Probably simply due to uploading a new patchset? -
Andreas Nedbal uploaded patch set 10
CR -1V +109/25/23, 16:14 -
Andreas Nedbal commented on patch set 10 09/25/23, 16:16
Reply
Oh, looks like I missed this one and either accidentally marked it as resolved or it was done so by the new patchset. Presets are adjusted now! -
core-ci voted on patch set 10 V +1 09/25/23, 16:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47163
-
Andreas Kienast voted on patch set 10 V +1 CR +1 09/26/23, 07:28
-
Stefan Bürk commented on patch set 10 V +2 CR +2 09/26/23, 07:51
GraphicalFunctions.php:723This method should get a rename if not falling (removed) in further refactorings. ``` determineFileExtensionToUse() ``` or something like that without naming exact file extensions. Along with adopting usages and so on. -
Stefan Bürk merged patch set 11 09/26/23, 07:51